addAddressBook and deleteAddressBook API calls #482

2013-09-05T12:33:53+02:00

grant-olson commented

2013-09-05 12:33:53 +02:00

(Migrated from github.com)

This pull request:

Adds add/deleteAddressBook APIs
Extracts address verification into reusable code
Makes some QT stuff re-renderable and exposes this externally so the API can refresh the GUI.

This pull request: - Adds add/deleteAddressBook APIs - Extracts address verification into reusable code - Makes some QT stuff re-renderable and exposes this externally so the API can refresh the GUI.

Atheros1 commented

2013-09-05 20:06:50 +02:00

(Migrated from github.com)

Excellent! It was definitely wise to move verifyAddress to its own function.

ralyodio commented

2013-09-05 23:10:49 +02:00

(Migrated from github.com)

the name is ambiguous. sounds like we're adding and deleting the entire addressbook. But good none-the-less. WIll be adding to Bmr tonight!

grant-olson commented

2013-09-05 23:12:48 +02:00

(Migrated from github.com)

@chovy I agree but that was consistent with the existing listAddressBook method, and the way the other list/add/delete methods work.

merlink01 commented

2013-09-06 02:24:01 +02:00

(Migrated from github.com)

Whats about list/add/delete Contacts?

ralyodio commented

2013-09-06 02:39:30 +02:00

(Migrated from github.com)

That makes sense, only terminology the client uses is AddressBook. I was thinking deleteFromAddressBook and addToAddressBook.

That makes sense, only terminology the client uses is AddressBook. I was thinking `deleteFromAddressBook` and `addToAddressBook`.

Atheros1 commented

2013-09-06 19:36:13 +02:00

(Migrated from github.com)

Then how about I change

listAddressBook
addAddressBook  and
deleteAddressBook

to

listAddressBookEntries
addAddressBookEntry  and
deleteAddressBookEntry

before too much time goes by.

Then how about I change ``` listAddressBook addAddressBook and deleteAddressBook ``` to ``` listAddressBookEntries addAddressBookEntry and deleteAddressBookEntry ``` before too much time goes by.

grant-olson commented

2013-09-06 19:48:22 +02:00

(Migrated from github.com)

That works for me.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-02-27#482