Bitmessage/PyBitmessage-2025-03-03
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

qrcode plugin fixes #1153

Merged
g1itch merged 5 commits from qrcode into v0.6 2018-03-14 14:02:39 +01:00
Conversation 6 Commits 5 Files Changed 4 +109 -108
g1itch commented 2018-03-12 11:08:38 +01:00 (Migrated from github.com)
Copy Link

Hello.

This is my technical debt on qrcode plugin:

  • all unused code removed;
  • menu entry is shown on any QTreeWidgetItem with address;
  • such plugins now have prefix address.;
  • 'BM:' is a schema for QR-code now.

Should I make that plugins also available for Address book and Blacklist entries?

Hello. This is my technical debt on qrcode plugin: - all unused code removed; - menu entry is shown on any `QTreeWidgetItem` with address; - such plugins now have prefix `address.`; - 'BM:' is a schema for QR-code now. Should I make that plugins also available for Address book and Blacklist entries?
PeterSurda commented 2018-03-13 11:06:13 +01:00 (Migrated from github.com)
Copy Link

Can look at the codacy review and add docstrings? Don't worry about the "name doesn't conform", I'll try to adjust the check so that it doesn't complain.

Can look at the codacy review and add docstrings? Don't worry about the "name doesn't conform", I'll try to adjust the check so that it doesn't complain.
PeterSurda commented 2018-03-13 14:55:57 +01:00 (Migrated from github.com)
Copy Link

I changed the method and function naming regexp, let's see if it is better now.

I changed the method and function naming regexp, let's see if it is better now.
PeterSurda commented 2018-03-13 15:11:41 +01:00 (Migrated from github.com)
Copy Link

Maybe it takes a while for the changes to kick in.

Maybe it takes a while for the changes to kick in.
PeterSurda (Migrated from github.com) reviewed 2018-03-14 07:31:57 +01:00
src/plugins/menu_qrcode.py
@ -0,0 +66,4 @@
self.label.setText(text)
self.image.setPixmap(
qrcode.make(text, image_factory=Image).pixmap())
self.setFixedSize(QtGui.QWidget.sizeHint(self))
PeterSurda (Migrated from github.com) commented 2018-03-14 07:31:57 +01:00

I think it should be bitmessage:BM-aldkfjaolsfkjalfgkalkg

I think it should be `bitmessage:BM-aldkfjaolsfkjalfgkalkg`
MahendraNG (Migrated from github.com) approved these changes 2018-03-14 13:50:19 +01:00
PeterSurda (Migrated from github.com) approved these changes 2018-03-14 13:53:45 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
MahendraNG
PeterSurda
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
refactoring
Milestone
No items
No Milestone v0.6.4
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-03-03#1153
No description provided.
Delete Branch "qrcode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?