Bitmessage/PyBitmessage-2025-03-03
Archived
2
0
Fork 0
Code Issues 167 Pull Requests 56 Actions Packages Projects Releases 5 Wiki Activity

Make addDataPadding method to avoid clutter. #668

Merged
ghost merged 2 commits from master into master 2014-07-14 20:12:07 +02:00
Conversation 2 Commits 2 Files Changed 5 +42 -36
ghost commented 2014-05-02 16:53:17 +02:00 (Migrated from github.com)
Copy Link

addDataPadding adds bytes with 0 value to pad message to desired length.

msg\x00\x00\x00\x00\x00\x00\x00\x00\x00 becomes addDataPadding('msg')

addDataPadding adds bytes with 0 value to pad message to desired length. `msg\x00\x00\x00\x00\x00\x00\x00\x00\x00` becomes `addDataPadding('msg')`
bmng-dev commented 2014-05-22 13:24:51 +02:00 (Migrated from github.com)
Copy Link

Good job. But it would be better to cache slices, strip the null bytes, use a compiled struct to unpack/pack the headers, and use a dispatcher.

Good job. But it would be better to cache slices, strip the null bytes, use a compiled struct to unpack/pack the headers, and use a dispatcher.
Atheros1 commented 2014-07-14 20:17:53 +02:00 (Migrated from github.com)
Copy Link

Thank you antius!

Thank you antius!
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working as it's supposed to
build
Related to building or build system
dependencies
Pull requests that update a dependency file
developers
The issue is relevant mainly for developers rather than users
documentation
duplicate
enhancement
New feature
formatting
Code or UI text formatting
invalid
legal
mobile
Frontend for mobile devices (kivy)
obsolete
packaging
performance
protocol
Protocol change
question
refactoring
regression
Some issue, fixed in the past, appears again
security
test
translation
usability
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
PeterSurda
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2025-03-03#668
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?