Bitmessage/bitmessage-js
2
0
Fork 1
Code Issues 1 Pull Requests 1 Actions Packages Releases Activity

Add fail tests

Browse Source
This commit is contained in:
Kagami Hiiragi 2015-01-11 18:27:14 +03:00
parent 4b2bb0ba51
commit 887a757f87
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/structs.js
View File

@ -198,10 +198,12 @@ exports.var_str = {
decode: function(buf) { decode: function(buf) {
var decoded = var_int.decode(buf); var decoded = var_int.decode(buf);
var strLength = decoded.value; var strLength = decoded.value;
var length = decoded.length + strLength;
assert(buf.length >= length, "Buffer is too small");
// XXX(Kagami): Spec doesn't mention encoding, using UTF-8. // XXX(Kagami): Spec doesn't mention encoding, using UTF-8.
var str = decoded.rest.slice(0, strLength).toString(); var str = decoded.rest.slice(0, strLength).toString();
var rest = decoded.rest.slice(strLength); var rest = decoded.rest.slice(strLength);
return {str: str, length: decoded.length + strLength, rest: rest}; return {str: str, length: length, rest: rest};
}, },
/** /**

14
test.js
View File

@ -4,8 +4,8 @@ var allTests = typeof window === "undefined" ?
window.ALL_TESTS; window.ALL_TESTS;
var bufferEqual = require("buffer-equal"); var bufferEqual = require("buffer-equal");
var bmcrypto = require("./lib/crypto");
var bitmessage = require("./lib"); var bitmessage = require("./lib");
var bmcrypto = require("./lib/crypto");
var structs = bitmessage.structs; var structs = bitmessage.structs;
var message = structs.message; var message = structs.message;
var var_int = structs.var_int; var var_int = structs.var_int;
@ -140,6 +140,9 @@ describe("Common structures", function() {
expect(res.str).to.equal("test"); expect(res.str).to.equal("test");
expect(res.length).to.equal(5); expect(res.length).to.equal(5);
expect(res.rest.toString("hex")).to.equal("ffffff"); expect(res.rest.toString("hex")).to.equal("ffffff");
// Truncated input.
expect(var_str.decode.bind(null, Buffer("04746573", "hex"))).to.throw(Error);
}); });
it("should encode", function() { it("should encode", function() {
@ -170,6 +173,9 @@ describe("Common structures", function() {
expect(res.length).to.equal(22); expect(res.length).to.equal(22);
expect(res.list.length).to.equal(5); expect(res.list.length).to.equal(5);
expect(res.rest.toString("hex")).to.equal("ffffff"); expect(res.rest.toString("hex")).to.equal("ffffff");
// Truncated input.
expect(var_int_list.decode.bind(null, Buffer("0501fd0400ff0004000000000000fd9c40fe000186", "hex"))).to.throw(Error);
}); });
it("should encode", function() { it("should encode", function() {
@ -305,6 +311,12 @@ describe("POW", function() {
expect(POW.check({nonce: 3122436, target: 4864647698763, initialHash: Buffer("8ff2d685db89a0af2e3dbfd3f700ae96ef4d9a1eac72fd778bbb368c7510cddda349e03207e1c4965bd95c6f7265e8f1a481a08afab3874eaafb9ade09a10880", "hex")})).to.be.false; expect(POW.check({nonce: 3122436, target: 4864647698763, initialHash: Buffer("8ff2d685db89a0af2e3dbfd3f700ae96ef4d9a1eac72fd778bbb368c7510cddda349e03207e1c4965bd95c6f7265e8f1a481a08afab3874eaafb9ade09a10880", "hex")})).to.be.false;
}); });
it("should fail on bad POW arguments", function() {
expect(POW.doAsync.bind(null, {target: 123, initialHash: 0})).to.throw(Error);
expect(POW.doAsync.bind(null, {target: 123, initialHash: Buffer("test")})).to.throw(Error);
expect(POW.doAsync.bind(null, {poolSize: -1, target: 123, initialHash: Buffer(64)})).to.throw(Error);
});
if (allTests) { if (allTests) {
it("should do a POW", function() { it("should do a POW", function() {
this.timeout(300000); this.timeout(300000);