From e40a40abd02aafebc444f34665715f8cf07c325a Mon Sep 17 00:00:00 2001 From: Kagami Hiiragi Date: Sun, 11 Jan 2015 20:28:12 +0300 Subject: [PATCH] Fix UserAgent.encode --- lib/user-agent.js | 4 ++-- test.js | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/user-agent.js b/lib/user-agent.js index 4f893b3..0844703 100644 --- a/lib/user-agent.js +++ b/lib/user-agent.js @@ -56,8 +56,8 @@ var encode = exports.encode = function(software) { var ua = software.map(function(soft) { var version = soft.version || "0.0.0"; var str = soft.name + ":" + version; - if (str.comments) { - str += "(" + comments + ")"; + if (soft.comments) { + str += "(" + soft.comments + ")"; } return str; }).join("/"); diff --git a/test.js b/test.js index f640d90..b49d1b7 100644 --- a/test.js +++ b/test.js @@ -402,6 +402,9 @@ describe("High-level classes", function() { expect(res.software).to.deep.equal([pybm]); expect(res.length).to.equal(21); expect(res.rest.toString("hex")).to.equal(""); + + ua = UserAgent.encode([{name: "test", "comments": "linux"}]); + expect(var_str.decode(ua).str).to.equal("/test:0.0.0(linux)/"); }); it("should encode bitmessage's user agent", function() {