Bitmessage/buildbot_multibuild
6
0
Fork 5
Code Issues 4 Pull Requests Projects Releases Wiki Activity

add webhook password #10

Merged
PeterSurda merged 1 commits from cis-muzahid/buildbot_multibuild:github_hook into master 2022-03-16 08:16:44 +01:00
Conversation 0 Commits 1 Files Changed 1 +13 -5
cis-muzahid commented 2022-03-11 16:52:49 +01:00
Member
Copy Link
No description provided.
PeterSurda reviewed 2022-03-14 08:05:40 +01:00
lib/worker_multibuild.py Outdated
@ -103,1 +100,4 @@
jobs = list_jobs(directory)
request_headers = {
"Content-Type": "application/x-www-form-urlencoded",
'Authorization': f'token {secret}',
PeterSurda commented 2022-03-14 08:05:40 +01:00
Owner
Copy Link

'X-Multibuild-Trigger'

`'X-Multibuild-Trigger'`
PeterSurda commented 2022-03-15 07:52:52 +01:00
Owner
Copy Link

would be better if " and ' were used consistently.

would be better if `"` and `'` were used consistently.
👍 1
PeterSurda marked this conversation as resolved
PeterSurda reviewed 2022-03-15 07:53:24 +01:00
PeterSurda left a comment
Owner
Copy Link

The `

The `
PeterSurda requested changes 2022-03-15 07:54:00 +01:00
PeterSurda left a comment
Owner
Copy Link

The variable secret is undefined. It needs to be loaded from the file.

The variable `secret` is undefined. It needs to be loaded from the file.
cis-muzahid force-pushed github_hook from f88306575a to da7a1435a8 2022-03-15 12:47:02 +01:00 Compare
PeterSurda requested changes 2022-03-15 14:50:20 +01:00
lib/worker_multibuild.py Outdated
@ -55,2 +52,4 @@
"""
def get_secret():
with open(path.join(os.environ['HOME'], "secret.key"),'r') as f:
PeterSurda commented 2022-03-15 14:50:15 +01:00
Owner
Copy Link

filename doesn't match the filename used in StringDownload

filename doesn't match the filename used in `StringDownload`
PeterSurda marked this conversation as resolved
cis-muzahid force-pushed github_hook from 9c751f4d4d to 83444728f3 2022-03-16 08:15:53 +01:00 Compare
PeterSurda approved these changes 2022-03-16 08:16:39 +01:00
PeterSurda merged commit 83444728f3 into master 2022-03-16 08:16:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#10
No description provided.
Delete Branch "cis-muzahid/buildbot_multibuild:github_hook"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?