add webhook password #10

Merged
PeterSurda merged 1 commits from cis-muzahid/buildbot_multibuild:github_hook into master 2022-03-16 07:16:44 +00:00
Member
No description provided.
cis-muzahid added 1 commit 2022-03-11 15:52:49 +00:00
PeterSurda reviewed 2022-03-14 07:05:40 +00:00
@ -103,1 +100,4 @@
jobs = list_jobs(directory)
request_headers = {
"Content-Type": "application/x-www-form-urlencoded",
'Authorization': f'token {secret}',
Owner

'X-Multibuild-Trigger'

`'X-Multibuild-Trigger'`
Owner

would be better if " and ' were used consistently.

would be better if `"` and `'` were used consistently.
PeterSurda marked this conversation as resolved
cis-muzahid added 1 commit 2022-03-14 18:04:48 +00:00
PeterSurda reviewed 2022-03-15 06:53:24 +00:00
PeterSurda left a comment
Owner

The `

The `
PeterSurda requested changes 2022-03-15 06:54:00 +00:00
PeterSurda left a comment
Owner

The variable secret is undefined. It needs to be loaded from the file.

The variable `secret` is undefined. It needs to be loaded from the file.
cis-muzahid added 1 commit 2022-03-15 09:32:04 +00:00
cis-muzahid force-pushed github_hook from f88306575a to da7a1435a8 2022-03-15 11:47:02 +00:00 Compare
PeterSurda requested changes 2022-03-15 13:50:20 +00:00
@ -55,2 +52,4 @@
"""
def get_secret():
with open(path.join(os.environ['HOME'], "secret.key"),'r') as f:
Owner

filename doesn't match the filename used in StringDownload

filename doesn't match the filename used in `StringDownload`
PeterSurda marked this conversation as resolved
cis-muzahid added 1 commit 2022-03-16 06:39:04 +00:00
cis-muzahid force-pushed github_hook from 9c751f4d4d to 83444728f3 2022-03-16 07:15:53 +00:00 Compare
PeterSurda approved these changes 2022-03-16 07:16:39 +00:00
PeterSurda merged commit 83444728f3 into master 2022-03-16 07:16:44 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/buildbot_multibuild#10
No description provided.