Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda opened issue Sysdeploy/cloud-init-cherrypy#6 2024-02-14 03:28:45 +01:00
baseurl is http, but maybe should be https
PeterSurda merged pull request PeterSurda/inoreader2readwise#3 2024-02-13 06:38:07 +01:00
Services/part2
PeterSurda pushed to main at PeterSurda/inoreader2readwise 2024-02-13 06:38:07 +01:00
a7a7ee3ee3 added login.html,home.html ,removed outer dockerfile,requirement.txt,main.txt
PeterSurda approved PeterSurda/inoreader2readwise#3 2024-02-13 06:37:57 +01:00
Services/part2
PeterSurda commented on issue Sysdeploy/openwrt#46 2024-02-13 04:38:05 +01:00
missing nvme temperature sensor reading

If the Ubuntu tests are successful I probably won’t use OpenWRT on devices that have NVMe after all, but since I don’t know yet, I’ll keep this open for now.

PeterSurda commented on issue Sysdeploy/openwrt#67 2024-02-12 11:50:20 +01:00
A small C program to read/write OTP registers for use with LUKS

Actually maybe I don't need this for openWRT.

PeterSurda commented on issue Sysdeploy/openwrt#67 2024-02-12 11:49:45 +01:00
A small C program to read/write OTP registers for use with LUKS

This isn't in C but maybe it's sufficient or can be adjusted: https://github.com/raspberrypi/usbboot/blob/master/tools/rpi-otp-private-key

PeterSurda commented on pull request PeterSurda/inoreader2readwise#3 2024-02-11 16:20:21 +01:00
Services/part2

sounds good

PeterSurda approved Sysdeploy/openwrt#68 2024-02-11 06:08:47 +01:00
Updating OpenWrt to 23.05.2

Looks ok, I can't test it at the moment but will in a couple of days.

PeterSurda approved PeterSurda/inoreader2readwise#3 2024-02-10 05:29:23 +01:00
Services/part2
PeterSurda pushed to main at PeterSurda/inoreader2readwise 2024-02-10 05:28:07 +01:00
02e7cd4be4 all template files(home,login)
PeterSurda merged pull request PeterSurda/inoreader2readwise#2 2024-02-10 05:28:06 +01:00
all template files(home,login)
PeterSurda commented on pull request PeterSurda/inoreader2readwise#2 2024-02-09 09:50:32 +01:00
all template files(home,login)

I think that the form with a button and hidden input fields is the cleanest, but my instinct tells me that it's too fancy: too fancy

PeterSurda commented on pull request PeterSurda/inoreader2readwise#2 2024-02-09 09:46:05 +01:00
all template files(home,login)

@shailaja You forgot to remove the script part in the template. Yes that's part of what I meant.

JS script is no more required as we'll send the created oauth_url from python code.

Or,…

PeterSurda suggested changes for PeterSurda/inoreader2readwise#2 2024-02-09 08:56:32 +01:00
all template files(home,login)

It's unfinished.

PeterSurda commented on pull request PeterSurda/inoreader2readwise#2 2024-02-09 02:29:59 +01:00
all template files(home,login)

It’s an overkill. If you prefer a button, you can still do a form with hidden inputs.

PeterSurda commented on pull request PeterSurda/inoreader2readwise#2 2024-02-08 11:46:45 +01:00
all template files(home,login)

why not just have a <a href="{{auth_url}blablabla">Login via InoReader</a>? Then you don't need javascript.

PeterSurda suggested changes for PeterSurda/inoreader2readwise#2 2024-02-08 11:46:45 +01:00
all template files(home,login)
PeterSurda commented on pull request PeterSurda/inoreader2readwise#2 2024-02-08 11:44:04 +01:00
all template files(home,login)

@PeterSurda this is what you wanted?

yes