Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-13 07:33:07 +01:00
Update webhook and setup

repository missing

PeterSurda commented on pull request Sysdeploy/openwrt#2 2023-01-13 07:29:36 +01:00
Building full image that's supposed to contain asterisk-chan-quectel

Notes:

  • missing packages to bundle in the image:

    • kmod-usb-audio
    • asterisk-app-sms
    • alsa-lib
  • user asterisk needs to be added to groups audio and dialout

PeterSurda commented on pull request Sysdeploy/openwrt#2 2023-01-13 05:38:43 +01:00
Building full image that's supposed to contain asterisk-chan-quectel

Test looks good. device state shows among other things

Voice: Yes
SMS: Yes

I was also able to successfully send a SMS from asterisk. I'm having trouble setting up voice and…

PeterSurda suggested changes for Sysdeploy/openwrt#2 2023-01-13 02:10:45 +01:00
Building full image that's supposed to contain asterisk-chan-quectel

While I think a part of the process can be skipped, it's exactly what I wanted, thanks. I haven't tested it yet but will shortly.

PeterSurda commented on pull request Sysdeploy/openwrt#2 2023-01-13 02:09:12 +01:00
Building full image that's supposed to contain asterisk-chan-quectel

See also from the documentation:

The output of make might contain WARNING: your configuration is out of sync. Please run make menuconfig, oldconfig or defconfig!. That warning is misleading and…

PeterSurda commented on pull request Sysdeploy/openwrt#2 2023-01-13 02:06:15 +01:00
Building full image that's supposed to contain asterisk-chan-quectel

I think lines 23 and 25 should be skipped, no? That would just recompile unnecessarily. The documentation doesn't mention these steps, only feeds update and then feeds install packagename.

PeterSurda suggested changes for Bitmessage/buildbot-transifex#1 2023-01-12 08:09:41 +01:00
Update webhook and setup

transifex_branch missing

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

maybe make "buildbot-transifex" a class variable or a module variable?

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

we can just use rendered_secret, not self.rendered_secret

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

something like translated_request or mapped_request would be more understandable. There is not response coming from transifex.

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

missing functionality, the project should be extracted from the repository variable

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

maybe add error handling, e.g.

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

duplicate

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

we already imported base64

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

no need logging

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

no need for logging

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

maybe just raise ValueError("Signature mismatch"), then it will propagate up

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

this line ('resource': ...) should be remove

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

maybe mapped_request

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1 2023-01-12 07:50:27 +01:00
Update webhook and setup

since we're raising inside the _verifyTransifexSignature, no need for if here anymore