Peter Šurda

PeterSurda suggested changes for Bitmessage/buildbot-transifex#1

2023-01-12 07:50:27 +01:00

Update webhook and setup

PeterSurda pushed to main at Sysdeploy/openwrt

2023-01-11 08:44:50 +01:00

45739cee6a Add packages

PeterSurda pushed to main at Sysdeploy/openwrt

2023-01-11 08:33:03 +01:00

fd1d4784c2 Add realtek USB driver and pciutils

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

language = payload.get('language', "None")

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

not translating anything. There is nothing here that translates transifex payload information into github information.

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

this is incomplete, we shouldn't proceed if the verification fails

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

not doing anything useful

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

options should probably be the last and default to None or something

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

transifex_to_github_map is an object attribute, no need to pass it around

PeterSurda suggested changes for Bitmessage/buildbot-transifex#1

2023-01-11 07:44:21 +01:00

Update webhook and setup

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

_HEADER_DATE

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

This is specific to a request so it shouldn't be a module variable. Wrong scope. At the very least, if there are multiple requests in parallel, this will cause collisions.

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

something like transifex_to_github_map is a better name

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

if you use .get with a default value, you can avoid try/except

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

this shouldn't be here

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

we're not doing anything with the return value of the verification

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

we shouldn't be modifying request_data, that's input

PeterSurda suggested changes for Bitmessage/buildbot-transifex#1

2023-01-10 08:10:41 +01:00

Update webhook and setup

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-09 07:56:58 +01:00

Update webhook and setup

_verifyTransifexSignature

PeterSurda commented on pull request Bitmessage/buildbot-transifex#1

2023-01-09 07:56:58 +01:00

Update webhook and setup

return True missing