Peter Šurda PeterSurda
0 Followers · 0 Following
  • Joined on 2020-04-27
Repositories
12
 Projects
1
 Packages Public Activity Starred Repositories
2
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-02 07:21:22 +01:00
worker and master splited

this is incomplete (doesn't filter directories, sockets, devices, etc). Better would be isfile and not islink

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-02 07:21:22 +01:00
worker and master splited

I think I didn't explain it well. It should look for subdirectories, but only at one level, and should ignore symlinked directories

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-02 07:21:22 +01:00
worker and master splited

python3

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#9 2022-03-02 07:21:22 +01:00
worker and master splited
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 12:09:05 +01:00
worker and master splited

should be two separate commands.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 12:09:05 +01:00
worker and master splited

I wouldn't use walk, we only need one level. Also, we need to add a check that Dockerfile, build.sh and test.sh are regular files and not symlinks (probably two checks needed per file so another function should be written for that)

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#9 2022-03-01 12:09:05 +01:00
worker and master splited
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 08:25:39 +01:00
worker and master splited

no os_codename

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 08:25:39 +01:00
worker and master splited

also here

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 08:25:39 +01:00
worker and master splited

add mkdir -p

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 08:25:39 +01:00
worker and master splited

remove os_codename, make it a variable, not an argument

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#9 2022-03-01 08:25:39 +01:00
worker and master splited
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 08:23:55 +01:00
worker and master splited

remove os_codename from arguments

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2022-03-01 07:28:23 +01:00
635963f74a fix mobile ui for scroll
PeterSurda merged pull request PeterSurda/Bitcoin_educational_videos#6 2022-03-01 07:28:22 +01:00
fix mobile ui for scroll
PeterSurda approved PeterSurda/Bitcoin_educational_videos#6 2022-03-01 07:28:12 +01:00
fix mobile ui for scroll
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#9 2022-03-01 07:24:09 +01:00
worker and master splited

--force-directories doesn't do what you think it does.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#8 2022-02-28 07:48:09 +01:00
worker and master splited

remove

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#8 2022-02-28 07:48:09 +01:00
worker and master splited

remove

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#8 2022-02-28 07:48:09 +01:00
worker and master splited

Please finish.