Peter Šurda PeterSurda

0 Followers · 0 Following

• Joined on 2020-04-27

Repositories

12

Projects

1

Packages Public Activity Starred Repositories

2

PeterSurda opened issue Bitmessage/buildbot_multibuild#3 2022-01-24 07:09:47 +00:00

Add setuptools

PeterSurda opened issue Bitmessage/buildbot_multibuild#2 2021-12-27 10:27:18 +00:00

Dockerfile syntax check

PeterSurda merged pull request Bitmessage/buildbot_multibuild#1 2021-12-26 08:05:49 +00:00

Added parent hook and some renderer

PeterSurda pushed to master at Bitmessage/buildbot_multibuild 2021-12-26 08:05:49 +00:00

6039d3a39b Removed parent hook

c9d1ffa117 Minor updates

bea032dc78 Updated multibuild and renderers

9a55687ec6 Added functions to add more steps to a buildFactory

1432e510a1 Add extra content in dockerfile based on OS

Compare 5 commits »

PeterSurda approved Bitmessage/buildbot_multibuild#1 2021-12-26 08:04:35 +00:00

Added parent hook and some renderer

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-26 03:15:04 +00:00

ca9ca8b573 DAOs -> ICOs

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-26 02:09:24 +00:00

Added parent hook and some renderer

I think repository and branch are a level higher.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-26 02:09:24 +00:00

Added parent hook and some renderer

For now it's probably ok. Over longer term however the os_codename isn't extracted from the parent (parent may be running something else than the child should), but from the child Dockerfile. The Dockerfile will begin with something like FROM ubuntu:bionic AS ..., so that determines the OS.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-26 02:09:24 +00:00

Added parent hook and some renderer

I'm not 100% sure this will pass properties. A safer solution would be to create a child of ShellCommand and call super with a constructed command.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-26 02:09:24 +00:00

Added parent hook and some renderer

I think we can remove this file.

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#1 2021-12-26 02:09:24 +00:00

Added parent hook and some renderer

We also need some way to construct the worker environment for the parent job

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 08:18:32 +00:00

Added parent hook and some renderer

should check for the correct property

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 08:18:32 +00:00

Added parent hook and some renderer

should also check the correct property

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#1 2021-12-25 08:18:32 +00:00

Added parent hook and some renderer

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 08:18:04 +00:00

Added parent hook and some renderer

I think they are still missing. Like repository and branch.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 05:57:14 +00:00

Added parent hook and some renderer

How about just

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 05:57:14 +00:00

Added parent hook and some renderer

No eval, it's evil. Maybe use a dict, or just try the multistage.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 05:57:14 +00:00

Added parent hook and some renderer

I think it should be

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 05:57:14 +00:00

Added parent hook and some renderer

proxied properties are missing

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 05:57:14 +00:00

Added parent hook and some renderer

should also have conditionals for build_script_exists. If it doesn't, this step is skipped and hidden.