Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 06:57:14 +01:00
Added parent hook and some renderer

I wouldn't change the directory, but just run it from it, i.e.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 06:57:14 +01:00
Added parent hook and some renderer

analogous changes as with build.sh

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-25 06:57:14 +01:00
Added parent hook and some renderer

should be the same as for bionic (different path, missing wget)

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#1 2021-12-25 06:57:14 +01:00
Added parent hook and some renderer

Not bad

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 07:36:53 +01:00
618921d21f minor changes
PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 07:12:14 +01:00
e23582d3f5 Add subtitles
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-24 05:03:50 +01:00
Added parent hook and some renderer

This repo is a kind of plugin, or module. It's not a full configuration for a buildbot instance. For deployment, you edit the instance configuration and include this module.

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 03:35:01 +01:00
c852512ec9 Add index.html
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-24 03:30:55 +01:00
Added parent hook and some renderer

Yes something like that, but it should be only the buildbot-specific stuff and not the whole existing Dockerfile

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-24 03:29:37 +01:00
Added parent hook and some renderer

Yes but we don't need to do this in this project. The master.cfg would look something like this:

parent = util.BuildFactory()
parent.addStep(steps.GitHub(
   …
PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 03:21:46 +01:00
13f5faa906 Embed videos
PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 03:13:31 +01:00
6651076590 Add subtitles
PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-24 03:02:31 +01:00
7a70f4b442 Part 3 video
PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-23 14:57:16 +01:00
7aa1ea560f Part 3 video
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 13:33:41 +01:00
Added parent hook and some renderer

There should be additional code for modifying the dockerfile. At the very least, it needs to install buildbot-worker and its dependencies, setup the default worker and run it in entrypoint. At the moment we can assume "apt", but in the future it should be able to detect the distro and adjust commands based on that.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 13:33:41 +01:00
Added parent hook and some renderer

I realised a problem. The code needs to be split between master and worker parts. Master code doesn't see the directories and files, and worker code doesn't have access to properties.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 13:33:41 +01:00
Added parent hook and some renderer

I think something more like the brew_package_steps from the config repo. One for adding steps for the parent BuildFactory, one for the children.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 13:33:41 +01:00
Added parent hook and some renderer

the "old" renderers (above) I would leave out of here and just keep them in the config repo. They aren't really related to this project.

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#1 2021-12-23 13:33:41 +01:00
Added parent hook and some renderer
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 12:02:28 +01:00
Added parent hook and some renderer

Something like

c['buildbotURL'].'/change_hook/base'

the buildbotURL could be passed as an argument to trigger_child_hooks.