yes. I think for an MVP we only need repository
and branch
, maybe revision
. For later, probably owner
and owners
(the way I have it setup now, it would allow people to re-run jobs for their…
multibuild.py
will have to be loaded from the buildbot config, just like now it's importing lib/wine.py
, for example. But it can be made into a separate pip module, for example, so it can be…
I think it would look something like this (still may need fine tuning):
request_data['properties'] = {
'repository': Util.Property('repository'),
'branch':…
We still need to construct the full URL, which consists of the URL of the buildbot server and the path for the base webhook. The latter part is statoc, I don't even think it's configurable in…
You mean it should come from util.Property("repository")?
Yes.
Do I need to save this repo url in some property?
You should pass it as it is. Similar with "branch". I don't think others…
node
and type
we don't need, that's for sysdeploy. we should put all the properties (build_script_available, test_script_available, dockerfile, ...) into this dict, there shouldn't be a sub-dict.
we also need to add the repo information, i.e. the pre-existing properties.
The hostname part of the request_url
should be dynamic. However since it doesn't depend on a specific job, it doesn't need to use interpolate.
typo (I forgot the correct syntax but at the very least s
is missing after )
)
this will be a separate BuildFactory
. There will be a child one (what you have above), and a parent one (what you have below)
lib/wine.py
should be renamed, maybe something like renderers.py