Peter Šurda PeterSurda
  • Joined on 2020-04-27
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:58:38 +01:00
Added parent hook and some renderer

yes. I think for an MVP we only need repository and branch, maybe revision. For later, probably owner and owners (the way I have it setup now, it would allow people to re-run jobs for their…

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:54:54 +01:00
Added parent hook and some renderer

multibuild.py will have to be loaded from the buildbot config, just like now it's importing lib/wine.py, for example. But it can be made into a separate pip module, for example, so it can be…

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:52:00 +01:00
Added parent hook and some renderer

I think it's fixed at /change_hook/base

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-23 11:45:21 +01:00
212ce3c88d Make music quieter in Part 1
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:27:57 +01:00
Added parent hook and some renderer

I think it would look something like this (still may need fine tuning):

request_data['properties'] = {
    'repository': Util.Property('repository'),
    'branch':…
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:23:55 +01:00
Added parent hook and some renderer

yes

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:23:38 +01:00
Added parent hook and some renderer

We still need to construct the full URL, which consists of the URL of the buildbot server and the path for the base webhook. The latter part is statoc, I don't even think it's configurable in…

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 11:22:16 +01:00
Added parent hook and some renderer

You mean it should come from util.Property("repository")?

Yes.

Do I need to save this repo url in some property?

You should pass it as it is. Similar with "branch". I don't think others…

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-23 09:43:14 +01:00
8c2fe2e031 Part 2 video
PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

node and type we don't need, that's for sysdeploy. we should put all the properties (build_script_available, test_script_available, dockerfile, ...) into this dict, there shouldn't be a sub-dict.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

we also need to add the repo information, i.e. the pre-existing properties.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

The hostname part of the request_url should be dynamic. However since it doesn't depend on a specific job, it doesn't need to use interpolate.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

this should be extracted from the current properties.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

this is fixed, derived from the base hook class.

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

this can be extracted from global variables

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

typo (I forgot the correct syntax but at the very least s is missing after ))

PeterSurda commented on pull request Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

this will be a separate BuildFactory. There will be a child one (what you have above), and a parent one (what you have below)

PeterSurda suggested changes for Bitmessage/buildbot_multibuild#1 2021-12-23 09:32:13 +01:00
Added parent hook and some renderer

lib/wine.py should be renamed, maybe something like renderers.py

PeterSurda pushed to master at PeterSurda/Bitcoin_educational_videos 2021-12-23 06:11:40 +01:00
2779176131 Part 1 update