The "Allow some of this data to be public" checkbox should be off for newly registered servers #10

New Issue

PeterSurda · 2024-06-13T18:54:39+02:00

PeterSurda commented

2024-06-13 18:54:39 +02:00

I don't know if what the name of the corresponding key is. I think it affects data submitted to geekbench or something, I don't think it's related to the web app itself, but better leave it off.

PeterSurda added the

enhancement

label 2024-06-13 18:54:39 +02:00

shailaja was assigned by PeterSurda

2024-06-13 18:54:39 +02:00

swapnil was assigned by PeterSurda

2024-06-13 18:54:39 +02:00

swapnil commented

2024-06-18 06:25:14 +02:00

The key is show_public in the api payload and response.

Things that I noted:

show_public is not being respected in the create API. No matter what value you send, the API accepts all but still considers 1. This can be verified by making a GET call for a given server.
show_public is only respected from the update call.

@shailaja currently we've put show_public in the NON_UPDATABLE_KEYS, we need to remove that.

The key is `show_public` in the api payload and response. Things that I noted: - `show_public` is not being respected in the create API. No matter what value you send, the API accepts all but still considers `1`. This can be verified by making a GET call for a given server. - `show_public` is only respected from the update call. @shailaja currently we've put `show_public` in the `NON_UPDATABLE_KEYS`, we need to remove that.

shailaja referenced a pull request that will close this issue

2024-06-18 07:40:20 +02:00

removed show_public from non updatable keys #12

swapnil closed this issue

2024-06-20 06:10:25 +02:00

Sign in to join this conversation.