Don't overwrite hardcoded values #4

New Issue

PeterSurda · 2024-06-08T07:49:01Z

PeterSurda commented

2024-06-08 07:49:01 +00:00

Keys like provider-id, location-id, are hard coded in the agent. This would overwrite the manually adjusted values in the app. Similarly, for RAM, reading it from /proc/meminfo doesn't show the amount of physical RAM available, but only that available outside of the kernel. So I don't want this overwritten, but at the same time when the amount of RAM changes, this should be reflected. So we should default to calculating RAM from dmidecode as that's accurate.

As per discussion in Skype, we should split the keys into two categories: those that should be set only during creation of a server record, and those that should be set either during creation or during an update. Things like serial numbers or primary IP (things that can be accurately determined by the agent and may change more frequently) are a good example of keys that are always updated, and the secondary IPs, name of the provider, how much it costs per month are a good example of keys that shouldn't be updated (the agent doesn't know how to obtain them, and they probably don't change that often).

Keys like provider-id, location-id, are hard coded in the agent. This would overwrite the manually adjusted values in the app. Similarly, for RAM, reading it from `/proc/meminfo` doesn't show the amount of physical RAM available, but only that available outside of the kernel. So I don't want this overwritten, but at the same time when the amount of RAM changes, this should be reflected. So we should default to calculating RAM from `dmidecode` as that's accurate. As per discussion in Skype, we should split the keys into two categories: those that should be set only during creation of a server record, and those that should be set either during creation or during an update. Things like serial numbers or primary IP (things that can be accurately determined by the agent and may change more frequently) are a good example of keys that are always updated, and the secondary IPs, name of the provider, how much it costs per month are a good example of keys that shouldn't be updated (the agent doesn't know how to obtain them, and they probably don't change that often).

PeterSurda added the

enhancement

label 2024-06-08 07:49:01 +00:00

shailaja was assigned by PeterSurda

2024-06-08 07:49:01 +00:00

swapnil was assigned by PeterSurda

2024-06-08 07:49:01 +00:00

PeterSurda added this to the Observability project 2024-06-08 07:49:01 +00:00

swapnil commented

2024-06-13 16:47:29 +00:00

Probably this can be closed? @PeterSurda