Sysdeploy/influx-smtp-gateway
2
0
Fork 1
Code Issues Pull Requests 2 Projects Releases Wiki Activity

Added Send mail functionality & Dockerized application #1

Merged
PeterSurda merged 11 commits from cis-kuldeep/influx-smtp-gateway:master into master 2022-02-21 06:41:14 +00:00
Conversation 1 Commits 11 Files Changed 7 +6 -2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1d69818718 - Show all commits

8
main.py
View File

@ -14,7 +14,7 @@ from email.mime.text import MIMEText
import cherrypy
import logging
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-09 06:58:20 +00:00
Outdated
Review
Copy Link

class name

class name
logging.basicConfig(filename='app.log', filemode='w',
logging.basicConfig(stream=sys.stdout,
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-17 04:32:28 +00:00
Outdated
Review
Copy Link

should log to stdout or stderr (research which one is more appropriate)

should log to stdout or stderr (research which one is more appropriate)
format='%(name)s - %(levelname)s - %(message)s')
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-09 06:58:32 +00:00
Outdated
Review
Copy Link

docstring

docstring
PeterSurda marked this conversation as resolved
PeterSurda commented 2022-02-07 06:36:27 +00:00
Review
Copy Link

this should go under __main__

this should go under `__main__`
@ -49,7 +49,7 @@ class SMTPWebhookApp:
try:
client = smtplib.SMTP(host=SMTP_SERVER_HOST, port=SMTP_SERVER_PORT)
except Exception as e:
except (smtplib.SMTPConnectionError, TimeoutError) as e:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-17 04:34:23 +00:00
Outdated
Review
Copy Link

except (SMTPConnectionError, TimeoutError) as e:

`except (SMTPConnectionError, TimeoutError) as e:`
time.sleep(0.2)
logging.error("To: {}, error: {}".format(TO_MAIL, e))
return {"status": 400, "message": "SMTP client error: {}.".format(
@ -109,6 +109,10 @@ if __name__ == "__main__":
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-16 06:36:44 +00:00
Outdated
Review
Copy Link

live data shouldn't be here, squash to get rid of it

live data shouldn't be here, squash to get rid of it
cherrypy.tree.mount(ROOT, config={})
if hasattr(ENGINE, "signal_handler"):
ENGINE.signal_handler.subscribe()
if hasattr(ENGINE, "console_control_handler"):
ENGINE.console_control_handler.subscribe()
try:
ENGINE.start()
except Exception: # pylint: disable=broad-except