Sysdeploy/influx-smtp-gateway
2
0
Fork 1
Code Issues Pull Requests 2 Projects Releases Wiki Activity

Added Send mail functionality & Dockerized application #1

Merged
PeterSurda merged 11 commits from cis-kuldeep/influx-smtp-gateway:master into master 2022-02-21 07:41:14 +01:00
Conversation 1 Commits 11 Files Changed 7 +4 -6
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 65bedd6356 - Show all commits

1
Dockerfile
View File

@ -15,3 +15,4 @@ RUN pip install -r requirements.txt
# copy project # copy project
COPY . . COPY . .
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-14 11:25:31 +01:00
Outdated
Review
Copy Link

let's call it something else

let's call it something else
ENTRYPOINT ["/usr/src/app/entrypoint.sh"]
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-10 07:59:35 +01:00
Outdated
Review
Copy Link

run as non-root

run as non-root
PeterSurda commented 2022-02-11 11:37:47 +01:00
Outdated
Review
Copy Link

this doesn't do anything. The Dockerfile should create a non-privileged user and then just before ENTRYPOINT have a corresponding USER instruction.

this doesn't do anything. The `Dockerfile` should create a non-privileged user and then just before `ENTRYPOINT` have a corresponding `USER` instruction.

5
docker-compose.yml
View File

@ -4,12 +4,7 @@ services:
web: web:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-10 08:00:20 +01:00
Outdated
Review
Copy Link

smtp-gateway:

`smtp-gateway:`
build: . build: .
command: python main.py command: python main.py
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-04 08:27:56 +01:00
Outdated
Review
Copy Link

perhaps this should be inside the Dockerfile

perhaps this should be inside the `Dockerfile`
volumes:
- mailsend_server:/usr/src/app/
ports: ports:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-09 07:57:55 +01:00
Outdated
Review
Copy Link

If we only use this internally inside a docker service, we should use expose, not port.

If we only use this internally inside a docker service, we should use `expose`, not `port`.
- 8081:8081 - 8081:8081
env_file: env_file:
- ./config.ini - ./config.ini
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-07 07:37:38 +01:00
Outdated
Review
Copy Link

wrong file

wrong file
volumes:
mailsend_server:

2
entrypoint.sh Executable file
View File

@ -0,0 +1,2 @@
#!/bin/sh
python main.py