Sysdeploy/influx-smtp-gateway
2
0
Fork 1
Code Issues Pull Requests 2 Projects Releases Wiki Activity

Added Send mail functionality & Dockerized application #1

Merged
PeterSurda merged 11 commits from cis-kuldeep/influx-smtp-gateway:master into master 2022-02-21 07:41:14 +01:00
Conversation 1 Commits 11 Files Changed 7 +32
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9e182c4b94 - Show all commits

17
Dockerfile Normal file
View File

@ -0,0 +1,17 @@
# pull official base image
FROM python:3.9.6-alpine
# set work directory
WORKDIR /usr/src/app
# set environment variables
ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1
# install dependencies
RUN pip install --upgrade pip
COPY ./requirements.txt .
RUN pip install -r requirements.txt
# copy project
COPY . .
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-14 11:25:31 +01:00
Outdated
Review
Copy Link

let's call it something else

let's call it something else

15
docker-compose.yml Normal file
View File

@ -0,0 +1,15 @@
version: '3.8'
services:
web:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-10 08:00:20 +01:00
Outdated
Review
Copy Link

smtp-gateway:

`smtp-gateway:`
build: .
command: python main.py
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-04 08:27:56 +01:00
Outdated
Review
Copy Link

perhaps this should be inside the Dockerfile

perhaps this should be inside the `Dockerfile`
volumes:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-09 07:57:55 +01:00
Outdated
Review
Copy Link

If we only use this internally inside a docker service, we should use expose, not port.

If we only use this internally inside a docker service, we should use `expose`, not `port`.
- mailsend_server:/usr/src/app/
ports:
- 8081:8081
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-07 07:37:38 +01:00
Outdated
Review
Copy Link

wrong file

wrong file
env_file:
- ./config.ini
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-04 08:25:46 +01:00
Outdated
Review
Copy Link

env_file is for shell variables, it won't work in this case. Instead we need a simple entrypoint.sh which will for example format the config.ini

`env_file` is for shell variables, it won't work in this case. Instead we need a simple `entrypoint.sh` which will for example format the `config.ini`
volumes:
mailsend_server:
PeterSurda marked this conversation as resolved Outdated
PeterSurda commented 2022-02-04 08:26:15 +01:00
Outdated
Review
Copy Link

we don't need a volume, the app will already be inside the dockerfile

we don't need a volume, the app will already be inside the dockerfile