Make sure some uci-defaults don’t run on upgrades #21

New Issue

PeterSurda · 2023-02-14T12:12:31+01:00

PeterSurda commented

2023-02-14 12:12:31 +01:00

According to documentation, uci-defaults run on upgrades: https://openwrt.org/docs/guide-developer/uci-defaults#ensuring_scripts_don_t_overwrite_custom_settingsimplementing_checks

For most of our scripts, we probably don't need them to run on upgrades, only on first install. For example adding a wan interface, and a firewall rule to allow ssh would now be repeated if I ran an upgrade. Therefore we should adjust them accordingly.

According to documentation, `uci-defaults` run on upgrades: https://openwrt.org/docs/guide-developer/uci-defaults#ensuring_scripts_don_t_overwrite_custom_settingsimplementing_checks For most of our scripts, we probably don't need them to run on upgrades, only on first install. For example adding a wan interface, and a firewall rule to allow ssh would now be repeated if I ran an upgrade. Therefore we should adjust them accordingly.

lee.miller was assigned by PeterSurda

2023-02-14 12:12:31 +01:00

lee.miller referenced this issue

2023-02-15 02:44:23 +01:00

Trying to make uci network configuration one time #22

PeterSurda commented

2023-07-04 08:13:29 +02:00

I think this has been resolved, we now have a /etc/config/defaults which tracks a per-script version.

I think this has been resolved, we now have a `/etc/config/defaults` which tracks a per-script version.

PeterSurda closed this issue

2023-07-04 08:13:29 +02:00

Sign in to join this conversation.