Commit Graph

2150 Commits

Author SHA1 Message Date
coffeedogs
e1c2e8ec46
Fixed: Responded to PR comments 2018-05-24 16:59:40 +01:00
coffeedogs
ab1dd319e3
Fixed: Code style and lint fixes 2018-05-24 10:53:11 +01:00
f97ada87
609a4a92e2
enable delayed POW checks
enable delayed POW checks via optional "receive time" argument
2018-05-23 03:38:05 +00:00
659d45bb15
Create default knownnodes if cannot read from file 2018-05-21 18:49:39 +03:00
b499e1bd22
Start without knownnodes if JSON got corrupted 2018-05-21 18:49:39 +03:00
5e72fdba17
Simplified addKnownNode() and added docstrings 2018-05-21 18:49:38 +03:00
67feb8fee9
Serialize knownnodes to json by default
Fixes #1232
2018-05-21 18:49:38 +03:00
f87ce4ad50
Moved reading knownnodes.dat into knownnodes module 2018-05-21 18:49:38 +03:00
ca42b4be63
flake8 for knownnodes 2018-05-21 18:49:38 +03:00
74ddda8775
helper_generic: imports in alphabetical order, import multiprocessing 2018-05-21 13:37:28 +03:00
4cf73675c2
flake8: bitmessagemain, class_singleCleaner, helper_generic, shutdown
and singleinstance
2018-05-21 13:37:23 +03:00
cb0996c6c8
flake8: api, debug 2018-05-21 12:20:57 +03:00
4610e1a0d7
Merge PR 1254 into v0.6 2018-05-21 11:03:21 +02:00
a43efc5b20
Merge PR 1253 into v0.6 2018-05-21 10:20:27 +02:00
78aa263964
Merge PR 1252 into v0.6 2018-05-21 09:07:56 +02:00
7313a4687e
Merge PR 1249 into v0.6 2018-05-21 08:56:36 +02:00
40dc7d330d
flake8: class_objectProcessor 2018-05-18 13:55:55 +03:00
31f107f048
flake8: bmconfigparser 2018-05-18 13:55:00 +03:00
coffeedogs
9263026bc8
Fixed: Addressed issues raised in PR 2018-05-17 10:51:21 +01:00
coffeedogs
ce955ba844
Fixed: Style and lint issues in src/qidenticon.py 2018-05-16 12:31:06 +01:00
coffeedogs
6c268ba22f
Fixed: Type error, reported from the bitmessage chan 2018-05-16 12:01:51 +01:00
coffeedogs
da87ae24ee
Fixed: Style and lint violations in src/bitmessageqt/__init__.py 2018-05-15 16:20:53 +01:00
coffeedogs
e0d31d77c9
Fixed: Style and lint violations in src/bitmessagecli.py 2018-05-15 16:15:44 +01:00
7445665963
Merge branch '1228' into v0.6 2018-05-10 08:44:46 +02:00
fdemortain
cafdff7f42
Update bitmessagecli.py 2018-05-09 14:09:42 +02:00
157590e0ee
Merge branch '1231' into v0.6 2018-05-09 14:08:11 +02:00
5d96a77a87
Merge branch '1233' into v0.6 2018-05-08 13:58:45 +02:00
coffeedogs
8979a1bef5
Fixed: Addressed PR comments 2018-05-08 12:53:58 +01:00
coffeedogs
ed4a092c51
Removed: # nosec directives until further security review. 2018-05-08 12:13:49 +01:00
coffeedogs
fe3a86d361
Fixed: Addressed PR comments 2018-05-07 11:50:51 +01:00
f97ada87
71d6fad242
pep8 fix
line length fixed by cleaning up an error message
2018-05-06 11:06:44 +00:00
f97ada87
bcaad3e0fb
fix issue 1236
fixes regression introduced in PR #1062 affecting default and minimum lengths of ackdata objects
2018-05-05 12:38:05 +00:00
coffeedogs
c99c3fc782
Fixed: Codacy issues in src/class_*.py 2018-05-03 19:05:39 +01:00
NourEddine K. Yassine
0cd6e687c9
Fixed Typo that prevented bitmessagecurses from running! 2018-05-02 18:24:11 +02:00
coffeedogs
dd1ee618a5
Fixed: Simple Codacy errors and warnings in src/helper_*
* Some local pickle operations and non-cryptographic random operations
were marked as safe to the bandit linter
 * A bandit config file was added and assert warnings are now ignored globally
 * Tightened up exception handling and code style
2018-05-02 15:52:47 +01:00
fdemortain
ac297e8d33
Typos
l 563 : # Generate Address -> # Delete Address
l 1381 : determinstic -> deterministic
2018-05-02 09:37:57 +02:00
f97ada87
54651c7598
fix logic bug in enableGUI implementation 2018-04-13 20:16:00 +10:00
bb433fc495
Merge branch '1216' into v0.6 2018-04-11 13:36:41 +02:00
4507464c56
Merge branch '1214' into v0.6 2018-04-11 13:19:53 +02:00
2de5fbe01a
Merge branch '1210' into v0.6 2018-04-10 13:47:25 +02:00
Mahendra Garg
d81fb4b63e
Made changes while import prctl 2018-04-10 14:19:34 +05:30
Mahendra Garg
a836d0a9af
Merge branch 'helper_threading_formating' of https://github.com/MahendraNG/PyBitmessage into helper_threading_formating 2018-04-10 13:25:37 +05:30
Mahendra Garg
6bce912a81
Fix undefined streamNumber bug 2018-04-10 12:44:32 +05:30
c76074df8c
Merge branch '1211' into v0.6 2018-04-10 08:16:56 +02:00
32ab6aaae5
Merge branch '1208' into v0.6 2018-04-10 08:12:25 +02:00
f97ada87
cb59b8abbd
component control switches 2018-04-09 15:03:02 +10:00
Mahendra
4840b2db5c
add docstring for sqlQuery and sqlBulkExecute methrod in helper_sql and removed query method of sqlBulkExecute class 2018-04-07 19:20:29 +05:30
Mahendra
5efb491349
add docstring for set_thread methrod in helper_msgcoding 2018-04-07 18:42:21 +05:30
Mahendra
f71f895a11
helper_inbox formating 2018-04-07 16:11:24 +05:30
Mahendra
e6e4c66010
helper_threading formating 2018-04-07 15:14:43 +05:30
Mahendra
a3dff6200e
helper_search formating 2018-04-07 14:10:50 +05:30
Mahendra
a012d4a707
helper_startup formating 2018-04-07 13:35:31 +05:30
Mahendra
498557a6d6
Removed unused variable queryreturn from helper_sql 2018-04-07 13:18:58 +05:30
Mahendra
21922251e2
helper_sql formating 2018-04-07 12:59:09 +05:30
62e80e9ca7
Merge branch '1206' into v0.6 2018-04-06 22:51:10 +02:00
Mahendra
5a2bac7e8c
Remove codacy error for docstring and reimport logger in helper_generic file 2018-04-06 19:09:56 +05:30
Mahendra
7052c734bd
Add log for thread error on helper_generic file
- Remove if condition for RegExParser
2018-04-06 19:00:32 +05:30
Mahendra
c0036d8c18
Add docstring in helper_generic.py 2018-04-06 18:33:30 +05:30
Mahendra
ed26782114
Add docstring in helper_ackPayload 2018-04-06 18:12:57 +05:30
Mahendra
442fe81e3a
helper_generic.py formating 2018-04-06 17:50:55 +05:30
Mahendra
a70b063004
helper_ackPayload formating 2018-04-06 16:21:29 +05:30
43a471a79b
Used state.testmode to indicate when operating in test mode 2018-04-05 13:48:13 +03:00
54c37150e0
Shutdown fixes
- tell sql thread to finish only after the other threads finished
- prevents other threads stalling on sql replies
2018-04-05 12:36:02 +02:00
12117ada99
Add docstring 2018-04-03 19:24:10 +02:00
ca7becb921
Download fixes
- in corner cases, download request could have contained an incorrect
  request length. I haven't actually checked if this can be triggered
  though
- wait for downloading until anti intersection delay expires. Doesn't
  necessarily mean that it will always avoid peer's anti intersection
  delay, but it's close enough
- tracks last time an object was received. If it was too long time ago,
  reset the download request queue. This avoid situations like when a
  request gets ignored during the anti intersection delay, but it will
  keep thinking there are still pending requests as long as not all
  missing objects have been requested. This caused staggered download
  (request 1000 items, wait 1 minute, request 1000 more, wait another
  minute, ...)
- with these fixes, you should end up downloading as fast as your
  network and CPU allow
- best tested with trustedpeer
2018-04-03 19:24:07 +02:00
6eb2155497
Another unicode -> str bug (#1194) 2018-04-03 15:11:46 +03:00
5e0e1c09b3
Merge branch '1197' into upstream-v0.6 2018-04-02 17:39:28 +02:00
0c9cb4824d
Memory leak (kind of) fix
- objectsKnownToThem is supposed to track if it's necessary to send inv
  commands to a peer
- it is supposed to enter garbage collection after 1 hour
  (ObjectTracker.trackingExpires)
- due to peer not announcing all objects, or announcing them before we
  announce, this contains excessive number of entries after connection
  is fully established.
- profiling revealed that this creates unnecessary memory to be kept
  allocated
- this patch will prevent tracking of entries sent during bigInv,
  reducing the memory "leak"
- it is possible, in theory, that this does have some negative effect,
  like increased bandwidth or neglecting to announce some invs. It
  probably doesn't though as my review of objectsKnownToThem occurrences
  didn't reveal any such case, and since the dict didn't track fully
  accurately anyway (so it would have already been broken if it was a
  problem), I consider it an acceptable risk at the moment. If it indeed
  causes problems, they can be solved separately
- I tested this on one of the bootstrap servers with little memory, and
  it increased the number of connections than can be handled by a factor
  of about 3.5
2018-04-01 11:39:02 +02:00
58c3dfb3d4
Testing mode for bitmessagemain 2018-03-29 15:55:28 +03:00
2268413cd0
Do not try to connect namecoin if dontconnect set in config (#1146) 2018-03-26 16:47:22 +03:00
73ebad4a4e
Merge branch '1179' into upstream-v0.6 2018-03-24 09:43:11 +01:00
6430ea7fe6
Merge branch '1171' into upstream-v0.6 2018-03-24 09:40:35 +01:00
cec8519e43
Added "apiinterface" and "apiport" to BMConfigDefaults 2018-03-22 17:50:26 +02:00
55d6239e3d
Merge branch '952' into upstream-v0.6 2018-03-22 16:16:24 +01:00
d974065f8e
Handle exceptions from python without ipv6 support 2018-03-22 17:13:34 +02:00
d7ac440a04
Merge branch '1172' into upstream-v0.6 2018-03-22 16:12:53 +01:00
9ccd3a0989
Prevent settingsDialog from setting dontconnect = false
if "Work offline" was checked in the ConnectDialog
2018-03-22 17:10:29 +02:00
6cefaf87e9
Module foldertree: changed subclassing order to reuse common code 2018-03-22 14:55:30 +02:00
90eca36b5d
Module foldertree: simplified a bit and did flake8 2018-03-22 14:55:25 +02:00
6562502416
Even more unused variables 2018-03-22 13:48:07 +02:00
e43bd36618
More unused variables 2018-03-22 13:23:36 +02:00
d91c3a6b0c
Removed unnecessary comment and percent formatting in logger.error 2018-03-22 12:13:47 +02:00
d447db907c
Address operations: simplified the code a bit 2018-03-22 12:13:47 +02:00
006b98389b
Address operations: flake8 2018-03-22 12:13:47 +02:00
cbb228db8b
Merge branch '1180' into upstream-v0.6 2018-03-22 11:08:51 +01:00
Mahendra
8d48164734
fix indentation error in dependency file 2018-03-22 15:27:37 +05:30
5721ca53fd
Merge branch '1174' into upstream-v0.6 2018-03-22 08:31:25 +01:00
Mahendra
1a36361ef9
replace all random.xxx with helper random function 2018-03-21 19:26:27 +05:30
d7cd294eb4
Merge branch '1173' into upstream-v0.6 2018-03-21 14:14:08 +01:00
Mahendra
6076e1832a
implement more helper random changes with replace random.xxx 2018-03-21 18:19:08 +05:30
f3960c1638
Merge branch '1170' into upstream-v0.6 2018-03-21 13:08:10 +01:00
Mahendra
1ad321b08a
replace random.xxx with calls to the helper_random function 2018-03-21 17:22:23 +05:30
08888117af
Merge branch '1169' into upstream-v0.6 2018-03-21 11:57:15 +01:00
Mahendra
48b8af975a
added random(sample, shuffle, randrange) methods in helper_random 2018-03-21 16:13:43 +05:30
Mahendra
ee7b591c6c
added docstring for requirement dependency 2018-03-21 15:47:55 +05:30
72299483c4
Do not duplicate avatar in address column of Address book 2018-03-14 16:34:03 +02:00
1e037024c3
Merge branch '1156' into upstream-v0.6 2018-03-14 13:59:40 +01:00
9bd60c4a0f
Merge branch '1153' into upstream-v0.6 2018-03-14 13:59:21 +01:00
50b74c2223
No lib symlinks in openwrt 2018-03-14 12:56:23 +02:00
0ef0e6b020
Added docstrings. Removed unused method Image.save(). 2018-03-14 08:57:51 +02:00