refactor: encaps create/update logic in upsert

This commit is contained in:
Swapnil 2024-06-25 15:15:03 +05:30
parent fa67103b20
commit 3940cbdbde
Signed by untrusted user: swapnil
GPG Key ID: 58029C48BB100574

View File

@ -244,6 +244,36 @@ class ServerManager:
return server['id'] return server['id']
return None return None
def upsert_server(self, post_data):
server_id = self.existing_server_id(post_data)
if server_id:
logging.info('Server already exists with id: {}, Updating...'.format(server_id))
response = self.update_server(post_data, server_id)
else:
logging.info('Server does not exist, Creating...')
response = self.create_server(post_data)
# Extract the server_id from the response
server_id = response.get('server_id', None)
if server_id is None:
logging.error('Failed to get server_id from response: {}'.format(response))
raise ValueError('Failed to get server_id from response')
return server_id
def upsert_note(self, note_data, server_id):
note_data['service_id'] = server_id
try:
note = self.get_note(server_id)
except urllib.error.HTTPError:
note = None
if note:
return self.update_note(note_data, server_id)
else:
return self.create_note(note_data)
def validate_env_vars(): def validate_env_vars():
api_key = os.getenv('AGENT_API') api_key = os.getenv('AGENT_API')
host = os.getenv('HOST') host = os.getenv('HOST')
@ -263,26 +293,11 @@ def main():
server_manager = ServerManager(host, api_key) server_manager = ServerManager(host, api_key)
# Check if the server already exists server_id = server_manager.upsert_server(post_data)
server_id = server_manager.existing_server_id(post_data) logging.info('Server id: {}'.format(server_id))
# If the server exists, update it
if server_id:
logging.info('Server already exists with id: {}, Updating...'.format(server_id))
logging.info(server_manager.update_server(post_data, server_id))
else:
logging.info('Server does not exist, Creating...')
logging.info(server_manager.create_server(post_data))
note_data = server_data.create_note_data(server_id) note_data = server_data.create_note_data(server_id)
try: server_manager.upsert_note(note_data, server_id)
note = server_manager.get_note(server_id)
except urllib.error.HTTPError:
note = None
if note:
server_manager.update_note(note_data, server_id)
else:
server_manager.create_note(note_data)
if __name__ == '__main__': if __name__ == '__main__':
main() main()