From 28d722e9c9941092d52d431d92c94e83f10f77fe Mon Sep 17 00:00:00 2001
From: Peter Surda <surda@economicsofbitcoin.com>
Date: Thu, 11 Feb 2021 11:09:24 +0100
Subject: [PATCH] Elcapitan VM fix

- forgot to change VM name
- also some code quality fixes in virt-install-all.sh
---
 virt-install-all.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/virt-install-all.sh b/virt-install-all.sh
index ef160d3..5e245ee 100755
--- a/virt-install-all.sh
+++ b/virt-install-all.sh
@@ -13,7 +13,7 @@ trusty()
 
     xml=$(mktemp)
 
-    virt-install -r $mempercore --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
+    virt-install -r "$mempercore" --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
         -n trusty_libvirt_"${hostname}_${id}" -w network=default --nographics \
         --disk path=/var/lib/libvirt/ephemeral/trusty_libvirt_"${hostname}_${id}".qcow2 \
         --disk path=/var/lib/libvirt/ephemeral/trusty_libvirt_"${hostname}_${id}".iso,device=cdrom \
@@ -39,7 +39,7 @@ xenial()
 
     xml=$(mktemp)
 
-    virt-install -r $mempercore --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
+    virt-install -r "$mempercore" --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
         -n xenial_libvirt_"${hostname}_${id}" -w network=default --nographics \
         --disk path=/var/lib/libvirt/ephemeral/xenial_libvirt_"${hostname}_${id}".qcow2 \
         --disk path=/var/lib/libvirt/ephemeral/xenial_libvirt_"${hostname}_${id}".iso,device=cdrom \
@@ -65,7 +65,7 @@ bionic()
 
     xml=$(mktemp)
     
-    virt-install -r $mempercore --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
+    virt-install -r "$mempercore" --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
         -n bionic_libvirt_"${hostname}_${id}" -w network=default --nographics \
         --disk path=/var/lib/libvirt/ephemeral/bionic_libvirt_"${hostname}_${id}".qcow2 \
         --disk path=/var/lib/libvirt/ephemeral/bionic_libvirt_"${hostname}_${id}".iso,device=cdrom \
@@ -91,7 +91,7 @@ focal()
 
     xml=$(mktemp)
     
-    virt-install -r $mempercore --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
+    virt-install -r "$mempercore" --vcpus=2,maxvcpus=2,sockets=1,cores=1,threads=2 \
         -n focal_libvirt_"${hostname}_${id}" -w network=default --nographics \
         --disk path=/var/lib/libvirt/ephemeral/focal_libvirt_"${hostname}_${id}".qcow2 \
         --disk path=/var/lib/libvirt/ephemeral/focal_libvirt_"${hostname}_${id}".iso,device=cdrom \
@@ -111,7 +111,7 @@ elcapitan()
     local cores
     id="$1"
 
-    virsh undefine elcapitan_"${hostname}_${id}"
+    virsh undefine elcapitan_libvirt_"${hostname}_${id}"
 
     xml=$(mktemp)
 
@@ -127,10 +127,10 @@ elcapitan()
         /var/lib/libvirt/ephemeral/enoch_rev2839_boot
 
     sed -Ei "
-        s#<name>.*<#<name>elcapitan_${hostname}_${id}<#;
+        s#<name>.*<#<name>elcapitan_libvirt_${hostname}_${id}<#;
         s#<vcpu (.*)>[0-9]+#<vcpu \\1>$threads#;
         s#<topology (.*)cores='[0-9]+'#<topology \\1cores='$cores'#;
-        s#<source file='(.*\\.qcow2)'#<source file='/var/lib/libvirt/ephemeral/elcapitan_${hostname}_${id}.qcow2'#;
+        s#<source file='(.*\\.qcow2)'#<source file='/var/lib/libvirt/ephemeral/elcapitan_libvirt_${hostname}_${id}.qcow2'#;
         " "$xml"
 
     virsh define "$xml"