From ee73ea1a31513e6e3165154e2c7ada15ea370d69 Mon Sep 17 00:00:00 2001
From: cp6 <cp6@users.noreply.github.com>
Date: Fri, 24 Jun 2022 11:17:59 +1000
Subject: [PATCH] Fixed YABs, disk speed and network foreign key on delete
 issues

Fixed YABs, disk speed and network foreign key on delete issues
---
 app/Http/Controllers/YabsController.php       |  9 +-------
 .../2022_05_09_114227_add_foreign_keys.php    |  2 +-
 ...22_06_24_010658_alter_yabs_foreign_key.php | 23 +++++++++++++++++++
 3 files changed, 25 insertions(+), 9 deletions(-)
 create mode 100644 database/migrations/2022_06_24_010658_alter_yabs_foreign_key.php

diff --git a/app/Http/Controllers/YabsController.php b/app/Http/Controllers/YabsController.php
index 4ac12f6..1eab347 100644
--- a/app/Http/Controllers/YabsController.php
+++ b/app/Http/Controllers/YabsController.php
@@ -133,16 +133,9 @@ class YabsController extends Controller
 
     public function destroy(Yabs $yab)
     {
-        $id = $yab->id;
-        $yabs = Yabs::find($id);
+        $yabs = Yabs::find($yab->id);
         $yabs->delete();
 
-        $disk = DiskSpeed::find($id);
-        $disk->delete();
-
-        $network = NetworkSpeed::find($id);
-        $network->delete();
-
         $update_server = DB::table('servers')
             ->where('id', $yab->server_id)
             ->update(['has_yabs' => 0]);
diff --git a/database/migrations/2022_05_09_114227_add_foreign_keys.php b/database/migrations/2022_05_09_114227_add_foreign_keys.php
index ee7764f..0351a18 100644
--- a/database/migrations/2022_05_09_114227_add_foreign_keys.php
+++ b/database/migrations/2022_05_09_114227_add_foreign_keys.php
@@ -37,7 +37,7 @@ class AddForeignKeys extends Migration
         });
 
         Schema::table('yabs', function (Blueprint $table) {
-            $table->foreign('server_id', 'yabs_fk_servers')->references('id')->on('servers');
+            $table->foreign('server_id', 'yabs_fk_servers')->references('id')->on('servers')->onDelete('cascade');
         });
 
         Schema::table('disk_speed', function (Blueprint $table) {
diff --git a/database/migrations/2022_06_24_010658_alter_yabs_foreign_key.php b/database/migrations/2022_06_24_010658_alter_yabs_foreign_key.php
new file mode 100644
index 0000000..dc1ddbe
--- /dev/null
+++ b/database/migrations/2022_06_24_010658_alter_yabs_foreign_key.php
@@ -0,0 +1,23 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up()
+    {
+        Schema::table('disk_speed', function (Blueprint $table) {
+            $table->dropForeign('ds_fk_yabs');
+
+            $table->foreign('id', 'ds_fk_yabs')->references('id')->on('yabs')->onDelete('cascade');
+        });
+
+        Schema::table('network_speed', function (Blueprint $table) {
+            $table->dropForeign('ns_fk_yabs');
+
+            $table->foreign('id', 'ns_fk_yabs')->references('id')->on('yabs')->onDelete('cascade');
+        });
+    }
+};