Bitmessage
/
MiNode
3
0
Fork 1
Code Pull Requests 2 Actions Activity

Enable python 3.11 and resolve TLS issues #1

Open
lee.miller wants to merge 6 commits from lee.miller/MiNode:ssl into v0.3
pull from: lee.miller/MiNode:ssl
merge into: Bitmessage:v0.3
Conversation 2 Commits 6 Files Changed 6 +64 -67
lee.miller commented 2023-10-21 00:57:12 +00:00
Contributor
Copy Link

Hi!

There were two branches: for testing on jammy and for a TLS issue with PyBitmessage 0.6.1. But when I applied the dumb fix 959d6ce6 for py311, another issue appeared, related to openssl-3.0 and TLSv1.3. And it's fixing right next to the previous one.

py310 still don't able to make 5 connections in the jammy containers though.

Hi! There were two branches: for [testing on jammy](https://buildbot.bitmessage.org/#/builders/33/builds/18131/steps/4/logs/stdio) and for a TLS issue with PyBitmessage 0.6.1. But when I applied the dumb fix 959d6ce6 for py311, another [issue appeared](https://buildbot.bitmessage.org/#/builders/33/builds/18129/steps/4/logs/stdio), related to openssl-3.0 and TLSv1.3. And it's fixing right [next to the previous one](https://git.bitmessage.org/lee.miller/MiNode/src/commit/06e3797e23ccf7812fb2e8bab66babdf2c618be0/minode/connection.py#L214). ~~py310 still don't able to make 5 connections in the jammy containers though.~~
lee.miller added 5 commits 2023-10-21 00:57:13 +00:00
lee.miller added 1 commit 2024-02-27 16:12:03 +00:00
lee.miller added 2 commits 2024-02-27 16:14:54 +00:00
lee.miller added 1 commit 2024-02-27 16:16:23 +00:00
lee.miller added 1 commit 2024-02-27 16:23:49 +00:00
lee.miller added 1 commit 2024-02-27 16:32:58 +00:00
lee.miller added 1 commit 2024-02-27 16:42:47 +00:00
lee.miller added 1 commit 2024-02-27 16:51:54 +00:00
lee.miller added 1 commit 2024-02-27 16:56:22 +00:00
lee.miller added 2 commits 2024-02-27 17:01:19 +00:00
lee.miller force-pushed ssl from 214559d1d1 to 59053b22cc 2024-02-27 17:08:26 +00:00 Compare
lee.miller added 1 commit 2024-02-27 17:09:45 +00:00
lee.miller added 1 commit 2024-02-27 17:55:45 +00:00
lee.miller force-pushed ssl from 49e27778bc to 7cb4d16167 2024-03-03 11:40:40 +00:00 Compare
lee.miller added 1 commit 2024-03-05 10:57:04 +00:00
lee.miller force-pushed ssl from beb27195aa to a62fc0e4c6 2024-03-05 19:31:38 +00:00 Compare
lee.miller force-pushed ssl from a62fc0e4c6 to 006522d5c1 2024-03-05 19:47:30 +00:00 Compare
lee.miller changed title from WIP: enable python 3.11 and resolve TLS issues to enable python 3.11 and resolve TLS issues 2024-03-05 19:56:24 +00:00
lee.miller commented 2024-03-05 19:59:03 +00:00
Author
Contributor
Copy Link

Using a gitea action together with buildbot_multibuild dir for jammy we can test py39,py310,p311 pretty well, including TestProcessNoI2P blind test.

Using a gitea action together with `buildbot_multibuild` dir for jammy we can test py39,py310,p311 pretty well, including `TestProcessNoI2P` blind test.
lee.miller changed title from enable python 3.11 and resolve TLS issues to Enable python 3.11 and resolve TLS issues 2024-03-05 19:59:38 +00:00
PeterSurda approved these changes 2024-03-07 11:48:09 +00:00
Dismissed
PeterSurda left a comment
Owner
Copy Link

Looks ok. Regarding the SSL/TLS versions, I remember that in old python 2.7.something there were very limited options to set minimum and maximum allowed versions, so I had to base the implementation even with higher versions of python based on what's supported by the lower versions, so that they remain compatible. This however may be revisited at some stage as this very old python (I think < 2.7.9) shouldn't be used.

Looks ok. Regarding the SSL/TLS versions, I remember that in old python 2.7.something there were very limited options to set minimum and maximum allowed versions, so I had to base the implementation even with higher versions of python based on what's supported by the lower versions, so that they remain compatible. This however may be revisited at some stage as this very old python (I think < 2.7.9) shouldn't be used.
lee.miller changed title from Enable python 3.11 and resolve TLS issues to WIP: Enable python 3.11 and resolve TLS issues 2024-03-11 12:24:47 +00:00
lee.miller added 1 commit 2024-03-11 16:52:16 +00:00
lee.miller force-pushed ssl from e9f1628b8a to df172af1f9 2024-03-12 01:53:30 +00:00 Compare
lee.miller changed title from WIP: Enable python 3.11 and resolve TLS issues to Enable python 3.11 and resolve TLS issues 2024-03-12 01:58:01 +00:00
lee.miller force-pushed ssl from df172af1f9 to 61d8a94402 2024-03-26 19:19:59 +00:00 Compare
lee.miller force-pushed ssl from 61d8a94402 to ba0fc737e0 2024-03-26 19:41:18 +00:00 Compare
lee.miller requested review from PeterSurda 2024-04-03 12:37:55 +00:00
PeterSurda approved these changes 2024-05-07 05:51:14 +00:00
lee.miller force-pushed ssl from ba0fc737e0 to fd68c6ebe2 2024-05-07 16:25:43 +00:00 Compare
lee.miller commented 2024-05-11 01:46:46 +00:00
Author
Contributor
Copy Link

Rebased

Rebased
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b lee.miller-ssl v0.3
git pull ssl

Step 2:

Merge the changes and update on Gitea.
git checkout v0.3
git merge --no-ff lee.miller-ssl
git push origin v0.3
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/MiNode#1
No description provided.
Delete Branch "lee.miller/MiNode:ssl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?