Bitmessage/MiNode
3
0
Fork 1
Code Pull Requests 9 Actions Activity

Enable python 3.11 and resolve TLS issues #1

Merged
PeterSurda merged 8 commits from lee.miller/MiNode:ssl into v0.3 2024-06-25 00:49:12 +02:00
Conversation 4 Commits 8 Files Changed 8 +73 -74
lee.miller commented 2023-10-21 02:57:12 +02:00
Collaborator
Copy Link

Hi!

There were two branches: for testing on jammy and for a TLS issue with PyBitmessage 0.6.1. But when I applied the dumb fix 959d6ce6 for py311, another issue appeared, related to openssl-3.0 and TLSv1.3. And it's fixing right next to the previous one.

py310 still don't able to make 5 connections in the jammy containers though.

Hi! There were two branches: for [testing on jammy](https://buildbot.bitmessage.org/#/builders/33/builds/18131/steps/4/logs/stdio) and for a TLS issue with PyBitmessage 0.6.1. But when I applied the dumb fix 959d6ce6 for py311, another [issue appeared](https://buildbot.bitmessage.org/#/builders/33/builds/18129/steps/4/logs/stdio), related to openssl-3.0 and TLSv1.3. And it's fixing right [next to the previous one](https://git.bitmessage.org/lee.miller/MiNode/src/commit/06e3797e23ccf7812fb2e8bab66babdf2c618be0/minode/connection.py#L214). ~~py310 still don't able to make 5 connections in the jammy containers though.~~
lee.miller force-pushed ssl from 214559d1d1 to 59053b22cc 2024-02-27 18:08:26 +01:00 Compare
lee.miller force-pushed ssl from 49e27778bc to 7cb4d16167 2024-03-03 12:40:40 +01:00 Compare
lee.miller force-pushed ssl from beb27195aa to a62fc0e4c6 2024-03-05 20:31:38 +01:00 Compare
lee.miller force-pushed ssl from a62fc0e4c6 to 006522d5c1 2024-03-05 20:47:30 +01:00 Compare
lee.miller changed title from WIP: enable python 3.11 and resolve TLS issues to enable python 3.11 and resolve TLS issues 2024-03-05 20:56:24 +01:00
lee.miller commented 2024-03-05 20:59:03 +01:00
Author
Collaborator
Copy Link

Using a gitea action together with buildbot_multibuild dir for jammy we can test py39,py310,p311 pretty well, including TestProcessNoI2P blind test.

Using a gitea action together with `buildbot_multibuild` dir for jammy we can test py39,py310,p311 pretty well, including `TestProcessNoI2P` blind test.
lee.miller changed title from enable python 3.11 and resolve TLS issues to Enable python 3.11 and resolve TLS issues 2024-03-05 20:59:38 +01:00
PeterSurda approved these changes 2024-03-07 12:48:09 +01:00
Dismissed
PeterSurda left a comment
Owner
Copy Link

Looks ok. Regarding the SSL/TLS versions, I remember that in old python 2.7.something there were very limited options to set minimum and maximum allowed versions, so I had to base the implementation even with higher versions of python based on what's supported by the lower versions, so that they remain compatible. This however may be revisited at some stage as this very old python (I think < 2.7.9) shouldn't be used.

Looks ok. Regarding the SSL/TLS versions, I remember that in old python 2.7.something there were very limited options to set minimum and maximum allowed versions, so I had to base the implementation even with higher versions of python based on what's supported by the lower versions, so that they remain compatible. This however may be revisited at some stage as this very old python (I think < 2.7.9) shouldn't be used.
lee.miller changed title from Enable python 3.11 and resolve TLS issues to WIP: Enable python 3.11 and resolve TLS issues 2024-03-11 13:24:47 +01:00
lee.miller force-pushed ssl from e9f1628b8a to df172af1f9 2024-03-12 02:53:30 +01:00 Compare
lee.miller changed title from WIP: Enable python 3.11 and resolve TLS issues to Enable python 3.11 and resolve TLS issues 2024-03-12 02:58:01 +01:00
lee.miller force-pushed ssl from df172af1f9 to 61d8a94402 2024-03-26 20:19:59 +01:00 Compare
lee.miller force-pushed ssl from 61d8a94402 to ba0fc737e0 2024-03-26 20:41:18 +01:00 Compare
lee.miller requested review from PeterSurda 2024-04-03 14:37:55 +02:00
PeterSurda approved these changes 2024-05-07 07:51:14 +02:00
Dismissed
lee.miller force-pushed ssl from ba0fc737e0 to fd68c6ebe2 2024-05-07 18:25:43 +02:00 Compare
lee.miller commented 2024-05-11 03:46:46 +02:00
Author
Collaborator
Copy Link

Rebased

Rebased
lee.miller force-pushed ssl from 5cb6637c96 to 12f6e34afe 2024-06-08 03:47:16 +02:00 Compare
lee.miller commented 2024-06-18 17:41:48 +02:00
Author
Collaborator
Copy Link

Actions stopped running in my repository. I'm getting page 500, when click on test.yml.

Actions stopped running in my repository. I'm getting page 500, when click on `test.yml`.
lee.miller force-pushed ssl from a19a43e970 to efeabcb4cf 2024-06-18 18:12:30 +02:00 Compare
lee.miller force-pushed ssl from 342d906446 to efeabcb4cf 2024-06-24 15:19:33 +02:00 Compare
PeterSurda approved these changes 2024-06-25 00:49:06 +02:00
PeterSurda merged commit efeabcb4cf into v0.3 2024-06-25 00:49:12 +02:00
lee.miller commented 2024-06-25 19:16:01 +02:00
Author
Collaborator
Copy Link

Cool. Now I can test my branches locally without merging the ssl. You can probably remove all the branches in this repo, except for the v0.3, master, proofofwork and queue. There will be PRs for the remaining work in progress soon.

Cool. Now I can test my branches locally without merging the `ssl`. You can probably remove all the branches in this repo, except for the `v0.3`, `master`, `proofofwork` and `queue`. There will be PRs for the remaining work in progress soon.
Sign in to join this conversation.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/MiNode#1
No description provided.
Delete Branch "lee.miller/MiNode:ssl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?