Bitmessage/MiNode
3
0
Fork 1
Code Pull Requests 9 Actions Activity

Don't set shared.hosts - unused (duplicated in i2p.listener) #18

Open
lee.miller wants to merge 1 commits from lee.miller/MiNode:memory into v0.3
pull from: lee.miller/MiNode:memory
merge into: Bitmessage:v0.3
Conversation 0 Commits 1 Files Changed 1 -1
lee.miller commented 2024-11-01 19:47:06 +01:00
Collaborator
Copy Link

Hi!

I removed unused setting of shared.hosts. I guess it was supposed to be used in i2p, but i2p.listener composes hosts on its own every time it's connected, so does the manager.

Or should I try instead to make persistent shared.hosts, used in both places, what do you think?

Hi! I removed unused setting of `shared.hosts`. I guess it was supposed to be used in i2p, but `i2p.listener` [composes]( https://git.bitmessage.org/Bitmessage/MiNode/src/branch/v0.3/minode/i2p/listener.py#L40) hosts on its own every time it's connected, so [does the manager](https://git.bitmessage.org/Bitmessage/MiNode/src/branch/v0.3/minode/manager.py#L105). Or should I try instead to make persistent `shared.hosts`, used in both places, what do you think?
lee.miller added 1 commit 2024-11-01 19:47:06 +01:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u memory:lee.miller-memory
git checkout lee.miller-memory

Merge

Merge the changes and update on Gitea.
git checkout v0.3
git merge --no-ff lee.miller-memory
git checkout v0.3
git merge --ff-only lee.miller-memory
git checkout lee.miller-memory
git rebase v0.3
git checkout v0.3
git merge --no-ff lee.miller-memory
git checkout v0.3
git merge --squash lee.miller-memory
git checkout v0.3
git merge --ff-only lee.miller-memory
git checkout v0.3
git merge lee.miller-memory
git push origin v0.3
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/MiNode#18
No description provided.
Delete Branch "lee.miller/MiNode:memory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?