Don't set shared.hosts - unused (duplicated in i2p.listener) #18

Merged

lee.miller merged 1 commits from lee.miller/MiNode:memory into v0.3 2025-01-18 01:53:37 +01:00

Conversation 0 Commits 1 Files Changed 1 -1

lee.miller commented 2024-11-01 19:47:06 +01:00

Member

Copy Link

Hi!

I removed unused setting of shared.hosts. I guess it was supposed to be used in i2p, but i2p.listener composes hosts on its own every time it's connected, so does the manager.

Or should I try instead to make persistent shared.hosts, used in both places, what do you think?

Hi! I removed unused setting of `shared.hosts`. I guess it was supposed to be used in i2p, but `i2p.listener` [composes]( https://git.bitmessage.org/Bitmessage/MiNode/src/branch/v0.3/minode/i2p/listener.py#L40) hosts on its own every time it's connected, so [does the manager](https://git.bitmessage.org/Bitmessage/MiNode/src/branch/v0.3/minode/manager.py#L105). Or should I try instead to make persistent `shared.hosts`, used in both places, what do you think?

lee.miller added 1 commit 2024-11-01 19:47:06 +01:00

Don't set shared.hosts - unused (duplicated in i2p.listener) c76a7556d7

lee.miller requested review from PeterSurda 2025-01-16 02:21:56 +01:00

PeterSurda approved these changes 2025-01-16 02:22:45 +01:00

lee.miller merged commit c76a7556d7 into v0.3 2025-01-18 01:53:37 +01:00

Sign in to join this conversation.

Reviewers

No reviewers

PeterSurda

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/MiNode#18

No description provided.