Improving the network communication #4

Merged

PeterSurda merged 12 commits from lee.miller/MiNode:network into v0.3 2024-07-15 05:58:57 +00:00

Conversation 0 Commits 12 Files Changed 10 +387 -104

lee.miller commented 2024-06-24 12:15:47 +00:00

Contributor

Copy Link

Hi!

In this changeset I covered some network functionality with tests and added minor features - handling the large time offset of a connected node and the network group.

With definition of a base class to subclass by Connection I solved some lint complaints and prepared for a future extensions such as tor, bootstrappers, special testing subclasses.

Hi! In this changeset I covered some network functionality with tests and added minor features - handling the large time offset of a connected node and the network group. With definition of a base class to subclass by `Connection` I solved some lint complaints and prepared for a future extensions such as tor, bootstrappers, special testing subclasses.

lee.miller added 10 commits 2024-06-24 12:15:48 +00:00

Define a base class for connection to subclass for special purposes edb641024d

A short test for normal connection (with timeout in 5 min) ba897c8d40

Define a static method network_group() in NetAddrNoPrefix ... 78f170451b

and use it in manager.

Check network group of connections in process test if it isn't for i2p cfd054fcf4

Add a test for connections with large time offset 131512a5e6

Add a test case for listener with a process running with --trusted-peer acee18f0c4

Correct position of the except clause in listener loop 110dfc3324

Run listener with a large time offset and ensure it's not connected ba95d046f9

Invalidate the version message with a large time offset 1ce65fca8a

Copy the relevant part of test_network_group() from PyBitmessage bec948cfba

lee.miller force-pushed network from 6479913d70 to a31e2f6ab2 2024-06-25 16:58:31 +00:00 Compare

lee.miller changed title from Improving the network communication to WIP: Improving the network communication 2024-06-25 17:08:46 +00:00

lee.miller force-pushed network from a31e2f6ab2 to 6146c6ccd6 2024-06-25 17:25:19 +00:00 Compare

lee.miller added 1 commit 2024-07-02 22:59:16 +00:00

Don't advertise self peer if reported IP is 127.0.0.1 906f35e25e

lee.miller force-pushed network from 906f35e25e to af5a8acd21 2024-07-03 23:44:43 +00:00 Compare

lee.miller added 3 commits 2024-07-07 22:46:03 +00:00

Add a test for addr with host 127.0.0.1 68bea10ab7

Check also the acceptable time offset 971b661d3c

Don't advertise self peer if reported IP is 127.0.0.1 1dac9f5d3f

lee.miller force-pushed network from 1dac9f5d3f to c6b5f490d9 2024-07-08 21:13:11 +00:00 Compare

lee.miller added 1 commit 2024-07-08 21:40:33 +00:00

Relax the condition in TestProcess.test_connections() a bit 425abe8a93

lee.miller force-pushed network from 425abe8a93 to b7b5baede3 2024-07-08 22:09:59 +00:00 Compare

lee.miller force-pushed network from b7b5baede3 to a451a255af 2024-07-09 02:41:54 +00:00 Compare

lee.miller changed title from WIP: Improving the network communication to Improving the network communication 2024-07-09 03:50:48 +00:00

lee.miller requested review from PeterSurda 2024-07-14 16:47:40 +00:00

PeterSurda approved these changes 2024-07-15 05:46:14 +00:00

PeterSurda merged commit a451a255af into v0.3 2024-07-15 05:58:57 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

PeterSurda

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/MiNode#4

No description provided.