api_client example standards validation #1491
No reviewers
Labels
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
No Milestone
No project
No Assignees
1 Participants
No due date set.
Dependencies
No dependencies set.
Reference: Bitmessage/PyBitmessage-2024-08-21#1491
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "final_code_quality_23"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PEP8 validations done.
Modified api_client file formatted with PEP8 standards and compatible with python3.
@ -66,0 +63,4 @@' you will have to put your own in.')# subject = 'subject!'.encode('base64')# message = 'Hello, this is the message'.encode('base64')# ackData = api.sendMessage('BM-Gtsm7PUabZecs3qTeXbNPmqx3xtHCSXF',As for me, this
printmakes no sense: it tells about the comment line which user doesn't see. Maybe for that reason it was commented (^ plenty of them ahead (8Are you a robot? Why don't you write a short human readable explanation for your changes? And maybe clarify the goal of them a bit?
This was a good choice for a PR, because it's example code and nothing critical. It also makes things compatible with python 3 and improves the code quality.
@ -66,0 +63,4 @@' you will have to put your own in.')# subject = 'subject!'.encode('base64')# message = 'Hello, this is the message'.encode('base64')# ackData = api.sendMessage('BM-Gtsm7PUabZecs3qTeXbNPmqx3xtHCSXF',just to unclutter the screen at runtime and keep syntax hilite