Bitmessage/PyBitmessage-2024-08-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

debian package building added #1675

Closed
navjotcis wants to merge 4 commits from bug-fixes8 into v0.6
pull from: bug-fixes8
merge into: Bitmessage:v0.6
Conversation 14 Commits 4 Files Changed 12 +133
navjotcis commented 2020-09-25 14:32:40 +02:00 (Migrated from github.com)
Copy Link

I have added debian package building with the reference of 5f955ba52f

I have added debian package building with the reference of https://git.bitmessage.org/citizenaspirant/PyBitmessage/commit/5f955ba52f10c6167e82ec870cbb327a6ca1de2d
PeterSurda (Migrated from github.com) reviewed 2020-09-25 14:32:40 +02:00
PeterSurda commented 2020-10-05 12:32:52 +02:00 (Migrated from github.com)
Copy Link

I tested, it builds, but haven't tried installing.

I tested, it builds, but haven't tried installing.
PeterSurda commented 2020-10-12 09:27:06 +02:00 (Migrated from github.com)
Copy Link

I would say I merge this and if it doesn't run, fix it separately, because having this in will allow me to add dpkg to buildbot.

I would say I merge this and if it doesn't run, fix it separately, because having this in will allow me to add dpkg to buildbot.
PeterSurda (Migrated from github.com) approved these changes 2020-10-12 09:27:55 +02:00
g1itch commented 2020-10-12 09:59:30 +02:00 (Migrated from github.com)
Copy Link

Why don't you put this into packages dir?

Why don't you put this into packages dir?
PeterSurda commented 2020-10-12 10:36:49 +02:00 (Migrated from github.com)
Copy Link

I don't know how to integrate it into dpkg-buildpackage if I move the files.

I don't know how to integrate it into `dpkg-buildpackage` if I move the files.
😕 1
g1itch (Migrated from github.com) reviewed 2020-10-12 10:50:31 +02:00
debian/rules
g1itch (Migrated from github.com) commented 2020-10-12 10:50:30 +02:00

Did you try --sourcedirectory=.. here?

Did you try --sourcedirectory=.. here?
navjotcis (Migrated from github.com) reviewed 2020-10-12 18:50:43 +02:00
debian/rules
navjotcis (Migrated from github.com) commented 2020-10-12 18:50:43 +02:00

image
I have done some changes, please look

![image](https://user-images.githubusercontent.com/33522186/95771608-fd798180-0cd8-11eb-81c4-784291ff24cf.png) I have done some changes, please look
PeterSurda (Migrated from github.com) reviewed 2020-10-12 19:24:23 +02:00
debian/rules
PeterSurda (Migrated from github.com) commented 2020-10-12 19:24:23 +02:00

add the argument to the existing command, don't add a new command

add the argument to the existing command, don't add a new command
navjotcis (Migrated from github.com) reviewed 2020-10-12 20:13:51 +02:00
debian/rules
navjotcis (Migrated from github.com) commented 2020-10-12 20:13:51 +02:00

ok now please review it
image

ok now please review it ![image](https://user-images.githubusercontent.com/33522186/95777954-c27d4b00-0ce4-11eb-92d9-57ba5e65daed.png)
g1itch (Migrated from github.com) reviewed 2020-10-12 20:14:21 +02:00
debian/rules
g1itch (Migrated from github.com) commented 2020-10-12 20:14:21 +02:00

@navjotcis I meant after moving the stuff to the packages dir.

@navjotcis I meant after moving the stuff to the packages dir.
g1itch (Migrated from github.com) reviewed 2020-10-13 15:05:05 +02:00
debian/rules
g1itch (Migrated from github.com) commented 2020-10-13 15:05:05 +02:00

Well, I checked: --sourcedirectory=.. not works.
): https://travis-ci.org/github/g1itch/PyBitmessage/builds/735388416

Well, I checked: --sourcedirectory=.. not works. ): https://travis-ci.org/github/g1itch/PyBitmessage/builds/735388416
g1itch commented 2020-10-13 17:22:30 +02:00 (Migrated from github.com)
Copy Link

Also maybe get rid of https://github.com/Bitmessage/PyBitmessage/tree/v0.6/packages/unmaintained/debian?

Also maybe get rid of https://github.com/Bitmessage/PyBitmessage/tree/v0.6/packages/unmaintained/debian?
g1itch commented 2020-10-13 21:53:19 +02:00 (Migrated from github.com)
Copy Link

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903
navjotcis (Migrated from github.com) reviewed 2020-10-14 16:49:54 +02:00
debian/rules
navjotcis (Migrated from github.com) commented 2020-10-14 16:49:53 +02:00

yes it is failing the build

yes it is failing the build
navjotcis commented 2020-10-14 16:52:07 +02:00 (Migrated from github.com)
Copy Link

Now the build is successfully passing https://buildbot.bitmessage.org/#/builders/14/builds/161

Now the build is successfully passing https://buildbot.bitmessage.org/#/builders/14/builds/161
g1itch commented 2020-10-14 17:12:21 +02:00 (Migrated from github.com)
Copy Link

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.
navjotcis commented 2020-10-14 17:55:11 +02:00 (Migrated from github.com)
Copy Link

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

so I think I should use stable version like you have used bitmessage (0.6.3.2) stable; urgency=medium

> Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx. so I think I should use stable version like you have used `bitmessage (0.6.3.2) stable; urgency=medium`
g1itch commented 2020-10-15 10:31:33 +02:00 (Migrated from github.com)
Copy Link

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

so I think I should use stable version like you have used bitmessage (0.6.3.2) stable; urgency=medium

You can get actual version by python setup.py -V but it's not the point. For me the real problem with this PR is that it tends to become another unusable piece of garbage like fabfile, android_instruction.rst, src/bitmessagekivy, src/kivymd, src/navigationdrawer and like docs was before I fixed the documentation building process. You have some additional scripts in buildbot/dpkg task, including one, changing the version, which is needed for deb building. But your README says "Clone the source and run dpkg-buildpackage" and that's not gonna work for a general end user.

> > Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx. > > so I think I should use stable version like you have used `bitmessage (0.6.3.2) stable; urgency=medium` You can get actual version by `python setup.py -V` but it's not the point. For me the real problem with this PR is that it tends to become another unusable piece of garbage like `fabfile`, `android_instruction.rst`, `src/bitmessagekivy`, `src/kivymd`, `src/navigationdrawer` and like `docs` was before I fixed the documentation building process. You have some additional scripts in `buildbot/dpkg` task, including one, changing the version, which is needed for deb building. But your README says "Clone the source and run dpkg-buildpackage" and that's not gonna work for a general end user.
g1itch commented 2020-10-15 10:38:10 +02:00 (Migrated from github.com)
Copy Link

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903

Amendment: something like that, but demonstrating the build of non-empty and functional deb.

> That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903 Amendment: something like that, but demonstrating the build of non-empty and functional deb.
g1itch commented 2020-10-15 15:29:58 +02:00 (Migrated from github.com)
Copy Link

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903

Amendment: something like that, but demonstrating the build of non-empty and functional deb.

Like this: https://travis-ci.org/github/g1itch/PyBitmessage/jobs/736037581

As I suspected all that debian dir indeed is garbage. stdeb.cfg is enough. If someone needs that dir for some reason, it's generated by python setup.py --command-packages=stdeb.command debianize.

> > That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903 > > Amendment: something like that, but demonstrating the build of non-empty and functional deb. Like this: https://travis-ci.org/github/g1itch/PyBitmessage/jobs/736037581 As I suspected all that `debian` dir indeed is garbage. stdeb.cfg is enough. If someone needs that dir for some reason, it's generated by `python setup.py --command-packages=stdeb.command debianize`.
PeterSurda commented 2020-10-30 14:43:27 +01:00 (Migrated from github.com)
Copy Link

@g1itch Can you make a minimal PR from your debian branch? Then we can close this. No need to modify .travis.yml, I want the builds and the tests to be separate. As you can see buildbot's dpkg builder now succeeds, so it just needs fine tuning.

@g1itch Can you make a minimal PR from your `debian` branch? Then we can close this. No need to modify `.travis.yml`, I want the builds and the tests to be separate. As you can see buildbot's dpkg builder now succeeds, so it just needs fine tuning.
PeterSurda commented 2020-10-31 16:53:47 +01:00 (Migrated from github.com)
Copy Link

Superseded by #1686 .

Superseded by #1686 .
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.4
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-08-21#1675
No description provided.
Delete Branch "bug-fixes8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?