Bitmessage/PyBitmessage-2024-08-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Added flatpak build manifests with split dependencies #1768

Open
kdcis wants to merge 1 commits from kdcis/v0.6-flatpak into v0.6
pull from: kdcis/v0.6-flatpak
merge into: Bitmessage:v0.6
Conversation 2 Commits 1 Files Changed 4 +204
kdcis commented 2021-05-27 16:40:55 +02:00 (Migrated from github.com)
Copy Link

  • Added Flatpak build manifests under packages/flatpak/ directory

  • Added Flatpak build instructions under docs/ directory

- Added Flatpak build manifests under ```packages/flatpak/``` directory - Added Flatpak build instructions under ```docs/``` directory
PeterSurda (Migrated from github.com) requested changes 2021-06-04 01:13:03 +02:00
packages/flatpak/org.bitmessage.BaseApp.json
PeterSurda (Migrated from github.com) commented 2021-06-04 01:12:42 +02:00

you can put lines 53 and 54 together

you can put lines 53 and 54 together
PeterSurda (Migrated from github.com) requested changes 2021-06-23 10:45:37 +02:00
PeterSurda (Migrated from github.com) left a comment

Please update documentation

Please update documentation
docs/Flatpak_Build.md
@ -0,0 +4,4 @@
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed.
Follow the instructions for your distribution on [flathub](https://flatpak.org/setup/). The instructions there only cover the installation of `flatpak`, but
`flatpak-builder` should be the same.
PeterSurda (Migrated from github.com) commented 2021-06-23 10:44:18 +02:00

these are the packages (ubuntu 20.04) that need to be installed:

flatpak flatpak-builder git xz-utils elfutils librsvg2-common

these are the packages (ubuntu 20.04) that need to be installed: flatpak flatpak-builder git xz-utils elfutils librsvg2-common
g1itch (Migrated from github.com) reviewed 2021-06-23 16:08:03 +02:00
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
g1itch (Migrated from github.com) commented 2021-06-23 16:08:03 +02:00

Maybe also add this into index.rst with mdinclude? Under new section, like

Build Instructions
------------------

Or into README.md?

Maybe also add this into [index.rst](../../blob/v0.6/docs/index.rst) with mdinclude? Under new section, like ```reST Build Instructions ------------------ ``` Or into [README.md](../../blob/v0.6/README.md)?
kdcis (Migrated from github.com) reviewed 2021-06-23 16:18:59 +02:00
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
kdcis (Migrated from github.com) commented 2021-06-23 16:18:58 +02:00

Okay

Okay
kdcis (Migrated from github.com) reviewed 2021-06-23 16:20:00 +02:00
docs/Flatpak_Build.md
@ -0,0 +4,4 @@
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed.
Follow the instructions for your distribution on [flathub](https://flatpak.org/setup/). The instructions there only cover the installation of `flatpak`, but
`flatpak-builder` should be the same.
kdcis (Migrated from github.com) commented 2021-06-23 16:20:00 +02:00

Okay, I'll update the documentation

Okay, I'll update the documentation
g1itch (Migrated from github.com) reviewed 2021-06-23 16:26:54 +02:00
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
g1itch (Migrated from github.com) commented 2021-06-23 16:26:54 +02:00

Quick amendment: include a link to it, not the content, as mdinclude does, I'd mistaken.

Quick amendment: include a link to it, not the content, as mdinclude does, I'd mistaken.
g1itch (Migrated from github.com) reviewed 2021-06-23 19:44:35 +02:00
docs/index.rst
g1itch (Migrated from github.com) commented 2021-06-23 19:44:34 +02:00

InputError: [Errno 2] No such file or directory: '../../../../../../checkouts/latest/docs/..Flatpak_Build.md'.
Raw: https://readthedocs.org/api/v2/build/14080458.txt

InputError: [Errno 2] No such file or directory: '../../../../../../checkouts/latest/docs/..Flatpak_Build.md'. Raw: https://readthedocs.org/api/v2/build/14080458.txt
g1itch (Migrated from github.com) reviewed 2021-06-23 19:51:55 +02:00
docs/index.rst
g1itch (Migrated from github.com) commented 2021-06-23 19:51:55 +02:00

I meant something like this: https://pybitmessage-test.readthedocs.io/en/latest/#build-instructions
Did it with these changes: 0bedc5d

I meant something like this: https://pybitmessage-test.readthedocs.io/en/latest/#build-instructions Did it with these changes: 0bedc5d
g1itch (Migrated from github.com) reviewed 2021-06-23 19:56:04 +02:00
docs/Flatpak_Build.md
g1itch (Migrated from github.com) commented 2021-06-23 19:56:03 +02:00

Qt4, it is not QuickTime

Qt4, it is not QuickTime
g1itch commented 2021-06-23 20:18:49 +02:00 (Migrated from github.com)
Copy Link

Also, I don't get a point of documenting the maintenance tasks in such way. Why don't you just make a script buildscripts/flatpak.sh covering the steps under the ##Export header?

There supposed to be a builder on https://git.bitmessage.org/Bitmessage for building and uploading the bundle, which will be used as github check for a new code, like buildbot/PyBitmessage-wine32 and buildbot/dpkg.

Also, I don't get a point of documenting the maintenance tasks in such way. Why don't you just make a script `buildscripts/flatpak.sh` covering the steps under the `##Export` header? There supposed to be a builder on `https://git.bitmessage.org/Bitmessage` for building and uploading the bundle, which will be used as github check for a new code, like `buildbot/PyBitmessage-wine32` and `buildbot/dpkg`.
PeterSurda commented 2021-06-24 04:28:10 +02:00 (Migrated from github.com)
Copy Link

@g1itch I'm working on the buildbot integration.

@g1itch I'm working on the buildbot integration.
PeterSurda (Migrated from github.com) requested changes 2021-08-04 10:35:25 +02:00
PeterSurda (Migrated from github.com) left a comment

Clean up, rebase and then I'll look at it again.

Clean up, rebase and then I'll look at it again.
PeterSurda (Migrated from github.com) requested changes 2021-08-05 10:56:48 +02:00
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
## Requirements
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed.
PeterSurda (Migrated from github.com) commented 2021-08-05 10:56:14 +02:00

line too long

line too long
kdcis (Migrated from github.com) reviewed 2021-08-26 17:18:18 +02:00
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
## Requirements
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed.
kdcis (Migrated from github.com) commented 2021-08-26 17:18:18 +02:00

As it is a readme file, I don't think there would be any pylint line too long warning will happen.
Please confirm if still I need to break it.

As it is a readme file, I don't think there would be any pylint line too long warning will happen. Please confirm if still I need to break it.
PeterSurda (Migrated from github.com) reviewed 2021-08-27 09:08:17 +02:00
PeterSurda (Migrated from github.com) left a comment

I think we can merge it, the buildbot integration can be deployed later.

I think we can merge it, the buildbot integration can be deployed later.
docs/Flatpak_Build.md
@ -0,0 +1,97 @@
# PyBitmessage Linux flatpak instructions
## Requirements
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed.
PeterSurda (Migrated from github.com) commented 2021-08-27 09:06:39 +02:00

I don't have a strong opinion so we can probably just leave it as it is.

I don't have a strong opinion so we can probably just leave it as it is.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-08-21#1768
No description provided.
Delete Branch "kdcis/v0.6-flatpak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?