Bitmessage/PyBitmessage-2024-08-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Update winbuild.sh #1933

Closed
BeholdersEye wants to merge 4 commits from v0.6 into v0.6
pull from: v0.6
merge into: Bitmessage:v0.6
Conversation 18 Commits 4 Files Changed 1 +4 -4
BeholdersEye commented 2022-02-22 15:31:45 +01:00 (Migrated from github.com)
Copy Link

changes proof of work gcc machine architecture setting from "native" to "x86-64" and "i686" as appropriate to allow the resultant binary to run on CPU's other than the on which the binary was compiled.

https://github.com/Bitmessage/PyBitmessage/issues/1919

## changes proof of work gcc machine architecture setting from "native" to "x86-64" and "i686" as appropriate to allow the resultant binary to run on CPU's other than the on which the binary was compiled. ## https://github.com/Bitmessage/PyBitmessage/issues/1919
👍 1
g1itch (Migrated from github.com) reviewed 2022-02-22 15:39:32 +01:00
buildscripts/winbuild.sh
g1itch (Migrated from github.com) commented 2022-02-22 15:39:32 +01:00

why not just remove?

why not just remove?
g1itch commented 2022-02-22 15:42:27 +01:00 (Migrated from github.com)
Copy Link

You might want to add something like "(closes: #1919)" into the commit message.

You might want to add something like "(closes: #1919)" into the commit message.
BeholdersEye (Migrated from github.com) reviewed 2022-02-22 16:51:10 +01:00
buildscripts/winbuild.sh
BeholdersEye (Migrated from github.com) commented 2022-02-22 16:51:10 +01:00

Is that not what the minus signs indicate?

I sure didn't intend to leave "march=native" so hopefully github is not doing that.

Is that not what the minus signs indicate? I sure didn't intend to leave "march=native" so hopefully github is not doing that.
BeholdersEye commented 2022-02-22 16:52:10 +01:00 (Migrated from github.com)
Copy Link

You might want to add something like "(closes: #1919)" into the commit message.

I am not certain this closes #1919 yet but if it does I will keep that in mind.

> You might want to add something like "(closes: #1919)" into the commit message. I am not certain this closes #1919 yet but if it does I will keep that in mind.
g1itch (Migrated from github.com) reviewed 2022-02-22 17:12:18 +01:00
buildscripts/winbuild.sh
g1itch (Migrated from github.com) commented 2022-02-22 17:12:18 +01:00

I mean, aren't those values the defaults, that will be applied if you just remove the -march=native? Though maybe it's better to set that explicitly.

I mean, aren't those values the defaults, that will be applied if you just remove the `-march=native`? Though maybe it's better to set that explicitly.
g1itch commented 2022-02-22 17:19:02 +01:00 (Migrated from github.com)
Copy Link

You might want to add something like "(closes: #1919)" into the commit message.

I am not certain this closes #1919 yet but if it does I will keep that in mind.

I thought you could just download a build, because buildbot/PyBitmessage-wine32 is finished successfully. But https://download.bitmessage.org/builds is not available today );

> > You might want to add something like "(closes: #1919)" into the commit message. > > I am not certain this closes #1919 yet but if it does I will keep that in mind. I thought you could just download a build, because `buildbot/PyBitmessage-wine32` is finished successfully. But https://download.bitmessage.org/builds is not available today );
BeholdersEye (Migrated from github.com) reviewed 2022-02-22 18:08:11 +01:00
buildscripts/winbuild.sh
BeholdersEye (Migrated from github.com) commented 2022-02-22 18:08:11 +01:00

It turns out that there is no default value for the march option.

There is no default in general, because it's platform-specific.

https://gcc-help.gcc.gnu.narkive.com/Z259fPcD/default-value-for-march-option

Though you can find what your platform will use as default (if it is not specified) with the command:

gcc -Q --help=target

https://stackoverflow.com/questions/27786932/what-is-the-default-for-gcc-march-option

It turns out that there is no default value for the march option. > There is no default in general, because it's platform-specific. https://gcc-help.gcc.gnu.narkive.com/Z259fPcD/default-value-for-march-option Though you can find what your platform will use as default (if it is not specified) with the command: gcc -Q --help=target https://stackoverflow.com/questions/27786932/what-is-the-default-for-gcc-march-option
BeholdersEye commented 2022-02-22 18:08:48 +01:00 (Migrated from github.com)
Copy Link

You might want to add something like "(closes: #1919)" into the commit message.

I am not certain this closes #1919 yet but if it does I will keep that in mind.

I thought you could just download a build, because buildbot/PyBitmessage-wine32 is finished successfully. But https://download.bitmessage.org/builds is not available today );

https://download.bitmessage.org/snapshots/ is available and there is a new build for today there but I am uncertain whether that build incorporates this pull request as it has not yet been merged.

> > > You might want to add something like "(closes: #1919)" into the commit message. > > > > > > I am not certain this closes #1919 yet but if it does I will keep that in mind. > > I thought you could just download a build, because `buildbot/PyBitmessage-wine32` is finished successfully. But https://download.bitmessage.org/builds is not available today ); https://download.bitmessage.org/snapshots/ is available and there is a new build for today there but I am uncertain whether that build incorporates this pull request as it has not yet been merged.
g1itch commented 2022-02-22 18:11:04 +01:00 (Migrated from github.com)
Copy Link

https://download.bitmessage.org/snapshots/ is available and there is a new build for today there but I am uncertain whether that build incorporates this pull request as it has not yet been merged.

snapshots are for merges into v0.6, so you cannot check the snapshot before the merge

> https://download.bitmessage.org/snapshots/ is available and there is a new build for today there but I am uncertain whether that build incorporates this pull request as it has not yet been merged. snapshots are for merges into `v0.6`, so you cannot check the snapshot before the merge
PeterSurda commented 2022-02-23 07:34:23 +01:00 (Migrated from github.com)
Copy Link

I can tell buildbot to build a debug binary and it will then be available for upload

I can tell buildbot to build a debug binary and it will then be available for upload
PeterSurda commented 2022-02-23 07:46:16 +01:00 (Migrated from github.com)
Copy Link

Binary from this PR: https://storage.bitmessage.org/binaries/Bitmessage_x86_7652.exe
It's a debug binary so it will open a console window and print a lot of log data, maybe it will even give helpful information in case it still doesn't work correctly.

Binary from this PR: https://storage.bitmessage.org/binaries/Bitmessage_x86_7652.exe It's a debug binary so it will open a console window and print a lot of log data, maybe it will even give helpful information in case it still doesn't work correctly.
BeholdersEye commented 2022-02-23 13:47:43 +01:00 (Migrated from github.com)
Copy Link

Binary from this PR: https://storage.bitmessage.org/binaries/Bitmessage_x86_7652.exe It's a debug binary so it will open a console window and print a lot of log data, maybe it will even give helpful information in case it still doesn't work correctly.

Wonderful. Tested on the machines that displayed the C PoW missing message in the status and that were (effectively) unable to send messages due to proof of work taking forever. They no longer display the C PoW missing message and messages are sent as expected.

Pending merge, this closes #1919.

> Binary from this PR: https://storage.bitmessage.org/binaries/Bitmessage_x86_7652.exe It's a debug binary so it will open a console window and print a lot of log data, maybe it will even give helpful information in case it still doesn't work correctly. Wonderful. Tested on the machines that displayed the C PoW missing message in the status and that were (effectively) unable to send messages due to proof of work taking forever. They no longer display the C PoW missing message and messages are sent as expected. Pending merge, this closes #1919.
PeterSurda commented 2022-02-24 11:58:35 +01:00 (Migrated from github.com)
Copy Link

@BeholdersEye What's left to do is to sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead.

@BeholdersEye What's left to do is to sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead.
BeholdersEye commented 2022-02-24 13:09:46 +01:00 (Migrated from github.com)
Copy Link

@BeholdersEye What's left to do is to sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead.

@PeterSurda By all means do so.

> @BeholdersEye What's left to do is to sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead. @PeterSurda By all means do so.
BeholdersEye commented 2022-02-24 15:06:06 +01:00 (Migrated from github.com)
Copy Link

I added a gpg signature to my account but if you require email verification to fix bugs then I will let someone else do it. Feels like having a state funeral for a mosquito.

I added a gpg signature to my account but if you require email verification to fix bugs then I will let someone else do it. Feels like having a state funeral for a mosquito.
PeterSurda commented 2022-02-24 15:16:01 +01:00 (Migrated from github.com)
Copy Link

The signatures are mainly used to maintain the integrity of the repository rather than verifying the identity of contributors. If I make an exception then some automated scripts will stop working (i.e. it will look like someone is trying to change the repository without authorisation). I understand it's is a bit of a hassle for new contributors, I plan on adding it to the introductory videos so that it's easier.

The signatures are mainly used to maintain the integrity of the repository rather than verifying the identity of contributors. If I make an exception then some automated scripts will stop working (i.e. it will look like someone is trying to change the repository without authorisation). I understand it's is a bit of a hassle for new contributors, I plan on adding it to the introductory videos so that it's easier.
g1itch commented 2022-02-24 15:46:54 +01:00 (Migrated from github.com)
Copy Link

You might rebase and sign by your own.

Чт, 24 лют. 2022 14:01 користувач BeholdersEye @.***>
пише:

By all means do so.

—
Reply to this email directly, view it on GitHub
https://github.com/Bitmessage/PyBitmessage/pull/1933#issuecomment-1049788554,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6TVHAWHLHOKTJFKGWC2D3U4YMZFANCNFSM5PBSDIFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID:
@.***>

You might rebase and sign by your own. Чт, 24 лют. 2022 14:01 користувач BeholdersEye ***@***.***> пише: > By all means do so. > > — > Reply to this email directly, view it on GitHub > <https://github.com/Bitmessage/PyBitmessage/pull/1933#issuecomment-1049788554>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA6TVHAWHLHOKTJFKGWC2D3U4YMZFANCNFSM5PBSDIFQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you commented.Message ID: > ***@***.***> >
BeholdersEye commented 2022-02-24 16:01:57 +01:00 (Migrated from github.com)
Copy Link

sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead.

@PeterSurda please do so.

> sign the commit and rebase the PR. If you're having problems with that, I can assign someone to do that instead. @PeterSurda please do so.
BeholdersEye commented 2022-02-24 16:46:23 +01:00 (Migrated from github.com)
Copy Link

@g1itch

You might rebase and sign by your own.

I get the impression that the problem is that my gpg signature is not associated with a verified email address.

https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

https://docs.github.com/en/authentication/managing-commit-signature-verification/associating-an-email-with-your-gpg-key

Too bad it is not possible to verify with a bitmessage address.

@g1itch > You might rebase and sign by your own. I get the impression that the problem is that my gpg signature is not associated with a verified email address. https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification https://docs.github.com/en/authentication/managing-commit-signature-verification/associating-an-email-with-your-gpg-key Too bad it is not possible to verify with a bitmessage address.
BeholdersEye commented 2022-02-25 12:47:53 +01:00 (Migrated from github.com)
Copy Link

@PeterSurda

I would rather not share any more information on github.

Let me know if you need any more help from me to get this implemented in a release build.

@PeterSurda I would rather not share any more information on github. Let me know if you need any more help from me to get this implemented in a release build.
PeterSurda commented 2022-02-25 13:14:48 +01:00 (Migrated from github.com)
Copy Link

@BeholdersEye no need for you to do anything, I assigned a developer to the task, it may just take a couple of days

@BeholdersEye no need for you to do anything, I assigned a developer to the task, it may just take a couple of days
PeterSurda commented 2022-02-28 07:30:37 +01:00 (Migrated from github.com)
Copy Link

Closed with #1937

Closed with #1937
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-08-21#1933
No description provided.
Delete Branch "v0.6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?