allowing for max outbound connection configuration #940

2017-01-14T04:51:09+01:00

ghost commented

2017-01-14 04:51:09 +01:00

(Migrated from github.com)

This allows for the maximum number of connections to be configured in the settings UI.

PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:25:11 +01:00

.gitignore

PeterSurda (Migrated from github.com) commented

2017-02-12 19:25:11 +01:00

please change .dll to src/**/.dll

please change *.dll to src/**/*.dll

PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:27:27 +01:00

src/class_outgoingSynSender.py

						
				@ -78,7 +78,7 @@ class outgoingSynSender(threading.Thread, StoppableThread):

				            self.stop.wait(2)

PeterSurda (Migrated from github.com) commented

2017-02-12 19:27:27 +01:00

please change getint to safeGetInt

PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:28:21 +01:00

src/protocol.py

PeterSurda (Migrated from github.com) commented

2017-02-12 19:28:21 +01:00

please remove this whole hunk, this has been fixed

PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:28:39 +01:00

src/shared.py

PeterSurda (Migrated from github.com) commented

2017-02-12 19:28:39 +01:00

please remove this while hunk as well, this has been fixed as well

PeterSurda commented

2017-02-12 19:32:38 +01:00

(Migrated from github.com)

If you do the minor changes I commented upon inside the code, it's good to go, I just need to test if it works, which should be very quick. Please also rebase and PGP sign your commit, and when it's accepted, you can register here: https://tip4commit.com/github/Bitmessage/PyBitmessage and collect a tip. But it must be rebased and PGP signed so that I can do a fast-forward merge. Don't forget to add your PGP pubkey into your github profile.