Bitmessage/PyBitmessage-2024-11-29
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Use bytes() on keys to be hashable in Python3 #2243

Open
kashikoibumi wants to merge 1 commits from kashikoibumi/bytes-key into v0.6
pull from: kashikoibumi/bytes-key
merge into: Bitmessage:v0.6
Conversation 0 Commits 1 Files Changed 14 +96 -77
kashikoibumi commented 2024-05-26 17:28:32 +02:00 (Migrated from github.com)
Copy Link

This patch is a preparation to migration to Python3.

Use bytes() on keys to be hashable in Python3.
Hash keys used in hashtables must be hashable.
Although it is not problem in Python2, it is a problem in Python3.
When slice or memoryview of mutable byte array is used as hash key in Python3, an exception is raised.
To resolve the problem, this patch convert hash keys to immutable bytes by using bytes() function.

This patch is a preparation to migration to Python3. Use bytes() on keys to be hashable in Python3. Hash keys used in hashtables must be hashable. Although it is not problem in Python2, it is a problem in Python3. When slice or memoryview of mutable byte array is used as hash key in Python3, an exception is raised. To resolve the problem, this patch convert hash keys to immutable bytes by using bytes() function.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-11-29#2243
No description provided.
Delete Branch "kashikoibumi/bytes-key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?