Bitmessage/PyBitmessage-2024-11-30
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Quick workaround for BLOB as TEXT problem (#2247) #2248

Open
kashikoibumi wants to merge 3 commits from kashikoibumi/strict-blob into v0.6
pull from: kashikoibumi/strict-blob
merge into: Bitmessage:v0.6
Conversation 1 Commits 3 Files Changed 20 +376 -102
kashikoibumi commented 2024-05-30 11:23:22 +02:00 (Migrated from github.com)
Copy Link

Quick workaround for BLOB as TEXT problem (#2247).

This patch fixes each SQL query to be both workable with BLOB-keys and TEXT-keys.
In each query, it tries first BLOB-key by using sqlite3.Binary() function.
When it failed, then it tries next TEXT-key by using CAST(? AS TEXT) syntax.

The modifications are all around the code base where SQL queries exist, but the logic is simple.

Quick workaround for BLOB as TEXT problem (#2247). This patch fixes each SQL query to be both workable with BLOB-keys and TEXT-keys. In each query, it tries first BLOB-key by using sqlite3.Binary() function. When it failed, then it tries next TEXT-key by using CAST(? AS TEXT) syntax. The modifications are all around the code base where SQL queries exist, but the logic is simple.
kashikoibumi commented 2024-05-30 14:28:54 +02:00 (Migrated from github.com)
Copy Link

I have added a script to revert the BLOB-keys into TEXT-keys.

  • revert_blob_to_text.sh

By applying this script, old version of PyBitmessage before this patch can be run again.

I have added a script to revert the BLOB-keys into TEXT-keys. * revert_blob_to_text.sh By applying this script, old version of PyBitmessage before this patch can be run again.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-11-30#2248
No description provided.
Delete Branch "kashikoibumi/strict-blob"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?