Enable seamless, if crude, file attachment capability #1544

2019-10-21T02:06:51+02:00

sgj3 commented

2019-10-21 02:06:51 +02:00

(Migrated from github.com)

See PR #1540.

sgj3 commented

2019-10-21 02:11:45 +02:00

(Migrated from github.com)

This is just a placeholder. I will look into https://bitmessage.org/wiki/Extended_encoding and the src/messagetypes and improve my branch accordingly. For what it's worth, the attachment functionality in this PR already works, even if it is crude and limited.

g1itch commented

2019-10-22 17:42:26 +02:00

(Migrated from github.com)

This is just a placeholder. I will look into https://bitmessage.org/wiki/Extended_encoding and the src/messagetypes and improve my branch accordingly. For what it's worth, the attachment functionality in this PR already works, even if it is crude and limited.

Notice the new ability to create draft PR.

No matter which attachment method you use, you should probably check the file size, because of bitmessage message size limit: https://bitmessage.org/wiki/Protocol_specification#object

> This is just a placeholder. I will look into https://bitmessage.org/wiki/Extended_encoding and the src/messagetypes and improve my branch accordingly. For what it's worth, the attachment functionality in this PR already works, even if it is crude and limited. Notice the new ability to [create draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/). No matter which attachment method you use, you should probably check the file size, because of bitmessage message size limit: https://bitmessage.org/wiki/Protocol_specification#object

dimyme commented

2019-11-14 02:17:29 +01:00

(Migrated from github.com)

attaching files did work here. good job!

👍 1

dimyme commented

2019-11-20 01:34:57 +01:00

(Migrated from github.com)

However, this is the chance to win the filepicker war.

on many Linuces, you get dozens of filepickers which drive yo nuts. On KDE there is one central filepicker which is ignored by all the loudmouths out there. However, a patch for pyBM was already posted. KDE users will hate non-compliant filepickers such as the Gnome3 one. ideally we should have the patch ready for cherrypicking. seems, in Qt5 , that QtWidgets.QFileDialog.getOpenFileName() automatically honours the KDE filepicker via the "portal..." env setting. time to quit Qt4 !

However, this is the chance to win the filepicker war. on many Linuces, you get dozens of filepickers which drive yo nuts. On **KDE** there is one central filepicker which is ignored by all the loudmouths out there. However, a patch for pyBM was already posted. KDE users will hate non-compliant filepickers such as the Gnome3 one. ideally we should have the patch ready for cherrypicking. seems, in Qt5 , that **QtWidgets.QFileDialog.getOpenFileName()** automatically honours the KDE filepicker via the "portal..." env setting. time to quit Qt4 !

❤️ 1

dimyme commented

2019-11-29 15:44:26 +01:00

(Migrated from github.com)

using github web site, you can quickly merge this PR into your own fork onto a cherry-branch or sth

works like a charm ! CHERRY 1

using github web site, you can quickly merge this PR into your own fork onto a cherry-branch or sth works like a charm ! CHERRY 1

This repo is archived. You cannot comment on pull requests.

No reviewers