Changes based on style and lint checks. (final_code_quality_1) #1358

Merged

coffeedogs merged 1 commits from final_code_quality_1 into v0.6 2018-10-31 13:45:21 +01:00

Conversation 3 Commits 1 Files Changed 1 +78 -29

coffeedogs commented 2018-10-04 16:25:59 +02:00 (Migrated from github.com)

Copy Link

Changes based on style and lint checks. (final_code_quality_1)

Changes based on style and lint checks. (final_code_quality_1)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:19:31 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:19:31 +02:00

UI-related functionality for accounts

UI-related functionality for accounts

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:19:46 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:19:46 +02:00

QT UI color for an account

QT UI color for an account

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:20:13 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:20:13 +02:00

Account brush (for QT UI)

Account brush (for QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:20:45 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:20:45 +02:00

Folder brush (for QT UI)

Folder brush (for QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:21:15 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:21:15 +02:00

Set bitmessage address of the object

Set bitmessage address of the object

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:21:33 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:21:32 +02:00

Set number of unread messages

Set number of unread messages

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:21:47 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:21:47 +02:00

Set account enabled (QT UI)

Set account enabled (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:22:07 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:22:07 +02:00

Set account type (QT UI)

Set account type (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:22:48 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:22:48 +02:00

Default label (in case no label is set manually)

Default label (in case no label is set manually)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:23:23 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:23:23 +02:00

Override internal QT method for returning object data

Override internal QT method for returning object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:23:51 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:23:51 +02:00

Item in the account/folder tree representing a folder

Item in the account/folder tree representing a folder

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:24:04 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:24:04 +02:00

Set folder name (for QT UI)

Set folder name (for QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:24:25 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:24:25 +02:00

Override internal QT method for returning object data

Override internal QT method for returning object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:24:46 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:24:45 +02:00

Item in the account/folder tree representing an account

Item in the account/folder tree representing an account

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:25:07 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:25:07 +02:00

Override internal QT method for returning object data

Override internal QT method for returning object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:27:23 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:27:23 +02:00

Set address to object (for QT UI)

Set address to object (for QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:27:43 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:27:42 +02:00

Save account label (if you edit in the the UI, this will be triggered and will save it to keys.dat)

Save account label (if you edit in the the UI, this will be triggered and will save it to keys.dat)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:28:56 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:28:56 +02:00

Special treating of subscription addresses

Special treating of subscription addresses

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:29:12 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:29:12 +02:00

Set account type

Set account type

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:29:42 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:29:42 +02:00

Save subscription label to database

Save subscription label to database

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:30:01 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:30:01 +02:00

Set object label

Set object label

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:30:50 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:30:50 +02:00

Set/unset read state of an item

Set/unset read state of an item

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:31:04 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:31:04 +02:00

Return object data (QT UI)

Return object data (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:31:16 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:31:16 +02:00

Return object data (QT UI)

Return object data (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:31:33 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:31:33 +02:00

Address item in a messagelist

Address item in a messagelist

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:31:48 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:31:48 +02:00

Set label

Set label

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:32:02 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:32:02 +02:00

Return object data (QT UI)

Return object data (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:32:11 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:32:11 +02:00

Set object data

Set object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 16:32:26 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 16:32:26 +02:00

Message list subject item

Message list subject item

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:30:02 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:30:02 +02:00

Set subject

Set subject

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:30:15 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:30:15 +02:00

Return object data (QT UI)

Return object data (QT UI)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:31:59 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:31:59 +02:00

Addressbook item

Addressbook item

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:32:19 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:32:19 +02:00

Return object data

Return object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:32:32 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:32:32 +02:00

Set data

Set data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:32:46 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:32:46 +02:00

Addressbook label item

Addressbook label item

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:32:58 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:32:58 +02:00

Return object data

Return object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:33:28 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:33:28 +02:00

Addressbook address item

Addressbook address item

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:33:40 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:33:40 +02:00

Return object data

Return object data

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:34:16 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:34:16 +02:00

Addressbook completer

Addressbook completer

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:34:46 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:34:46 +02:00

Callback for cursor position change

Callback for cursor position change

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:35:30 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:35:30 +02:00

Split on semicolon

Split on semicolon

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:37:54 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:37:54 +02:00

Perform autocompletion (reimplemented QCompleter method)

Perform autocompletion (reimplemented QCompleter method)

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:52:35 +02:00

src/bitmessageqt/foldertree.py

PeterSurda (Migrated from github.com) commented 2018-10-14 17:52:34 +02:00

It probably should be just 4. It looks like it originated in f1b3041c9c but I can't find any reason for it.

It probably should be just 4. It looks like it originated in f1b3041c9c1b835af17bc9987667b13fbab7906d but I can't find any reason for it.

PeterSurda (Migrated from github.com) reviewed 2018-10-14 17:56:54 +02:00

PeterSurda (Migrated from github.com) left a comment

Add docstrings, otherwise ok

Add docstrings, otherwise ok

coffeedogs (Migrated from github.com) reviewed 2018-10-15 11:43:02 +02:00

src/bitmessageqt/foldertree.py

coffeedogs (Migrated from github.com) commented 2018-10-15 11:43:02 +02:00

Good catch! This is autopep8 doing 'the right thing' since numbers with a leading zero in them are interpreted as octal. Reverting to just 4...

Good catch! This is autopep8 doing 'the right thing' since numbers with a leading zero in them are interpreted as octal. Reverting to just `4`...

coffeedogs commented 2018-10-20 14:19:54 +02:00 (Migrated from github.com)

Copy Link

The flake8 check here is complaining of undefined name 'unicode', suggesting to me it's using python 3 rather than 2.

The flake8 check here is complaining of `undefined name 'unicode'`, suggesting to me it's using python 3 rather than 2.

PeterSurda commented 2018-10-20 16:28:42 +02:00 (Migrated from github.com)

Copy Link

@coffeedogs yea you already mentioned that, I haven't had time to check yet where the bug is.

@coffeedogs yea you already mentioned that, I haven't had time to check yet where the bug is.

PeterSurda commented 2018-10-27 09:34:58 +02:00 (Migrated from github.com)

Copy Link

@coffeedogs you were right, flake8 and pycodestyle were running in python3 mode. It's fixed now.

@coffeedogs you were right, flake8 and pycodestyle were running in python3 mode. It's fixed now.

PeterSurda (Migrated from github.com) approved these changes 2018-10-27 13:12:56 +02:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

PeterSurda

Labels

Clear labels   

bug

Something isn't working as it's supposed to

  

build

Related to building or build system

  

dependencies

Pull requests that update a dependency file

  

developers

The issue is relevant mainly for developers rather than users

  

documentation

  

duplicate

  

enhancement

New feature

  

formatting

Code or UI text formatting

  

invalid

  

legal

  

mobile

Frontend for mobile devices (kivy)

  

obsolete

  

packaging

  

performance

  

protocol

Protocol change

  

question

  

refactoring

  

regression

Some issue, fixed in the past, appears again

  

security

  

test

  

translation

  

usability

  

wontfix

No Label

bug

build

dependencies

developers

documentation

duplicate

enhancement

formatting

invalid

legal

mobile

obsolete

packaging

performance

protocol

question

refactoring

regression

security

test

translation

usability

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-05#1358

No description provided.