Minimal useragent validation #1840

2021-09-04T22:23:30+02:00

g1itch commented

2021-09-04 22:23:30 +02:00

(Migrated from github.com)

Hello!

This may seem a bit controversial patch, but the Protocol specifies the exact format for the user agent which turns out to be a BIP14 blueprint, and it in turn refers to RFC1945.

Hello! This may seem a bit controversial patch, but the Protocol [specifies](https://pybitmessage-test.readthedocs.io/en/doc/useragent.html) the exact format for the user agent which turns out to be a [BIP14](https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki) blueprint, and it in turn refers to RFC1945.

PeterSurda (Migrated from github.com) approved these changes 2021-09-05 06:53:14 +02:00

PeterSurda (Migrated from github.com) left a comment

Reviewing the references it looks the only place where this makes an impact is in the network status tab in the Qt interface, the debug log would still show the actual string. That makes sense to me.

This repo is archived. You cannot comment on pull requests.

No reviewers

PeterSurda