Bitmessage/PyBitmessage-2024-12-08
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Code quality #1773

Open
PeterSurda wants to merge 1 commits from PeterSurda/cq101 into v0.6
pull from: PeterSurda/cq101
merge into: Bitmessage:v0.6
Conversation 0 Commits 1 Files Changed 2 +10 -2
PeterSurda commented 2021-06-02 09:50:37 +02:00 (Migrated from github.com)
Copy Link

A couple of code quality fixes.

A couple of code quality fixes.
g1itch (Migrated from github.com) reviewed 2021-06-02 14:55:36 +02:00
src/network/udp.py
@ -24,3 +24,3 @@
# pylint: disable=bad-super-call
# pylint: disable=bad-super-call, access-member-before-definition
super(BMProto, self).__init__(sock=sock)
self.verackReceived = True
g1itch (Migrated from github.com) commented 2021-06-02 14:55:36 +02:00 
super(UDPSocket, self).__init__(sock=sock)

?

```python super(UDPSocket, self).__init__(sock=sock) ``` ?
g1itch (Migrated from github.com) reviewed 2021-08-09 11:19:15 +02:00
src/network/udp.py
@ -104,3 +107,4 @@
# pylint: disable=no-self-use
return True
def bm_command_pong(self):
g1itch (Migrated from github.com) commented 2021-08-09 11:19:15 +02:00

This is more of inheritance flow. Maybe UDPSocket should inherit from some more basic class?

This is more of inheritance flow. Maybe `UDPSocket` should inherit from some more basic class?
g1itch (Migrated from github.com) reviewed 2021-08-09 11:26:10 +02:00
src/network/udp.py
@ -23,3 +23,3 @@
def __init__(self, host=None, sock=None, announcing=False):
# pylint: disable=bad-super-call
# pylint: disable=bad-super-call, access-member-before-definition
super(BMProto, self).__init__(sock=sock)
g1itch (Migrated from github.com) commented 2021-08-09 11:26:10 +02:00

This is a bug: https://github.com/PyCQA/pylint/issues/2315

This is a bug: https://github.com/PyCQA/pylint/issues/2315
PeterSurda (Migrated from github.com) reviewed 2021-08-09 12:27:09 +02:00
src/network/udp.py
@ -104,3 +107,4 @@
# pylint: disable=no-self-use
return True
def bm_command_pong(self):
PeterSurda (Migrated from github.com) commented 2021-08-09 12:27:09 +02:00

Perhaps.

Perhaps.
Jeroenvb3 (Migrated from github.com) reviewed 2022-12-21 11:12:00 +01:00
src/network/udp.py
@ -23,3 +23,3 @@
def __init__(self, host=None, sock=None, announcing=False):
# pylint: disable=bad-super-call
# pylint: disable=bad-super-call, access-member-before-definition
super(BMProto, self).__init__(sock=sock)
Jeroenvb3 (Migrated from github.com) commented 2022-12-21 11:12:00 +01:00

The linked bug has been fixed. The ignore shouldn't be needed anymore.

The linked bug has been fixed. The ignore shouldn't be needed anymore.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-08#1773
No description provided.
Delete Branch "PeterSurda/cq101"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?