Bitmessage/PyBitmessage-2024-12-09
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Removed unreachable and unused/dead code #1152

Closed
venkateshpitta wants to merge 6 commits from master into master
pull from: master
merge into: Bitmessage:master
Conversation 4 Commits 6 Files Changed 75 +1551 -1550
venkateshpitta commented 2018-03-11 23:28:59 +01:00 (Migrated from github.com)
Copy Link

Code contributions to the Bitmessage project

  • try to explain what the code is about
  • try to follow PEP0008
  • make the pull request against the "v0.6" branch
  • it should be possible to do a fast-forward merge of the pull requests
  • PGP-sign the commits included in the pull request
  • You can get paid for merged commits if you register at Tip4Commit

If for some reason you don't want to use github, you can submit the patch using Bitmessage to the "bitmessage" chan, or to one of the developers.

Translations

For helping with translations, please use Transifex. There is no need to submit pull requests for translations.
For translating technical terms it is recommended to consult the Microsoft Language Portal.

## Code contributions to the Bitmessage project - try to explain what the code is about - try to follow [PEP0008](https://www.python.org/dev/peps/pep-0008/) - make the pull request against the ["v0.6" branch](https://github.com/Bitmessage/PyBitmessage/tree/v0.6) - it should be possible to do a fast-forward merge of the pull requests - PGP-sign the commits included in the pull request - You can get paid for merged commits if you register at [Tip4Commit](https://tip4commit.com/github/Bitmessage/PyBitmessage) If for some reason you don't want to use github, you can submit the patch using Bitmessage to the "bitmessage" chan, or to one of the developers. ## Translations For helping with translations, please use [Transifex](https://www.transifex.com/bitmessage-project/pybitmessage/). There is no need to submit pull requests for translations. For translating technical terms it is recommended to consult the [Microsoft Language Portal](https://www.microsoft.com/Language/en-US/Default.aspx).
PeterSurda commented 2018-03-12 00:11:04 +01:00 (Migrated from github.com)
Copy Link

Hello,

a couple of comments.

  • the pull request isn't against v0.6 branch, I actually removed some obsolete files in the meantime
  • the commit isn't pgp signed. Please create a PGP key and upload it to your github account (under Settings). Then you can sign the commits with git commit -s or you can set the signing options in the git configuration for the project
Hello, a couple of comments. - the pull request isn't against v0.6 branch, I actually removed some obsolete files in the meantime - the commit isn't pgp signed. Please create a PGP key and upload it to your github account (under Settings). Then you can sign the commits with `git commit -s` or you can set the signing options in the git configuration for the project
venkateshpitta commented 2018-03-15 04:52:53 +01:00 (Migrated from github.com)
Copy Link

Is anyone looking at this? any comment is welcome

Is anyone looking at this? any comment is welcome
PeterSurda commented 2018-03-15 07:09:58 +01:00 (Migrated from github.com)
Copy Link

Well I already made the organisational comments. Looking through the changes, some of it do look like obsolete code but aren't as they are a part of an object or a dictionary and without them the code would break.

Well I already made the organisational comments. Looking through the changes, some of it do look like obsolete code but aren't as they are a part of an object or a dictionary and without them the code would break.
venkateshpitta commented 2018-03-24 01:14:41 +01:00 (Migrated from github.com)
Copy Link

Added .travis.yml. Lacking tests, it fails. Also, made a project specific requirements.txt to be used by Travis.

Added .travis.yml. Lacking tests, it fails. Also, made a project specific requirements.txt to be used by Travis.
PeterSurda (Migrated from github.com) reviewed 2018-03-24 09:47:46 +01:00
.travis.yml
@ -13,3 +7,1 @@
- python-pyqt5
- tor
- xvfb
- "2.6"
PeterSurda (Migrated from github.com) commented 2018-03-24 09:47:46 +01:00

Doesn't work on 2.6, needs at least 2.7.2 (possible 2.7.6 even).

Doesn't work on 2.6, needs at least 2.7.2 (possible 2.7.6 even).
PeterSurda (Migrated from github.com) reviewed 2018-03-24 09:48:16 +01:00
requirements.txt
@ -8,1 +1,3 @@
xvfbwrapper;platform_system=="Linux"
setuptools==38.5.2
numpy==1.13.3
AppKit==0.2.8
PeterSurda (Migrated from github.com) commented 2018-03-24 09:48:16 +01:00

I am not familiar with this.

I am not familiar with this.
PeterSurda (Migrated from github.com) reviewed 2018-03-24 09:48:56 +01:00
requirements.txt
@ -9,0 +7,4 @@
msgpack_python==0.5.6
prctl==1.0.1
pybloom==1.1
pybloomfiltermmap==0.3.15
PeterSurda (Migrated from github.com) commented 2018-03-24 09:48:55 +01:00

Bloom filters are just for some experiments and aren't actually needed at the moment.

Bloom filters are just for some experiments and aren't actually needed at the moment.
PeterSurda (Migrated from github.com) requested changes 2018-03-24 09:49:32 +01:00
PeterSurda (Migrated from github.com) left a comment
  • I think you shouldn't specify the exact library versions, perhaps just the minimal.
  • also the PR is still against the master branch rather than v0.6
  • please create a new PR, against v0.6, with just the travis/gitignore/requirements
- I think you shouldn't specify the exact library versions, perhaps just the minimal. - also the PR is still against the master branch rather than v0.6 - please create a new PR, against v0.6, with just the travis/gitignore/requirements
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-09#1152
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?