Bitmessage/PyBitmessage-2024-12-10
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

replace print statements with logger #1688

Closed
navjotcis wants to merge 2 commits from bug-fixes14 into v0.6
pull from: bug-fixes14
merge into: Bitmessage:v0.6
Conversation 3 Commits 2 Files Changed 25 +160 -146
navjotcis commented 2020-11-12 18:13:39 +01:00 (Migrated from github.com)
Copy Link

I have replaced print statement with logger for below given module
network/randomtrackingdict.py
singleinstance.py

I have replaced print statement with logger for below given module `network/randomtrackingdict.py` `singleinstance.py`
PeterSurda (Migrated from github.com) requested changes 2020-11-16 09:10:35 +01:00
PeterSurda (Migrated from github.com) left a comment
  • the test in randomtrackingdict should be refactored as a unit test
  • remove singleinstnace from PR
  • filesystem is OK
- the test in randomtrackingdict should be refactored as a unit test - remove singleinstnace from PR - filesystem is OK
PeterSurda (Migrated from github.com) requested changes 2020-11-16 22:03:34 +01:00
PeterSurda (Migrated from github.com) left a comment

Move tests into unit tests.

Move tests into unit tests.
PeterSurda commented 2020-11-21 11:12:36 +01:00 (Migrated from github.com)
Copy Link
  • remove main section from randomtrackingdict.py
  • fix errors reported by travis
- remove main section from `randomtrackingdict.py` - fix errors reported by travis
PeterSurda (Migrated from github.com) requested changes 2020-12-19 20:01:36 +01:00
PeterSurda (Migrated from github.com) left a comment

Please do the requested changes and fix code quality.

Please do the requested changes and fix code quality.
src/tests/test_randomtrackingdict.py
PeterSurda (Migrated from github.com) commented 2020-12-19 19:55:09 +01:00

If I remember right, this should be replaced with a test failure.

If I remember right, this should be replaced with a test failure.
PeterSurda (Migrated from github.com) commented 2020-12-19 19:55:50 +01:00

I think this should also be replaced with a test failure.

I think this should also be replaced with a test failure.
PeterSurda (Migrated from github.com) commented 2020-12-19 20:00:50 +01:00

This is debugging information. We should check if this is not too slow. Let's say all values of a[x + 1] - a[x] need to be less than 10.0.

This is debugging information. We should check if this is not too slow. Let's say all values of `a[x + 1] - a[x]` need to be less than `10.0`.
PeterSurda commented 2020-12-19 20:05:15 +01:00 (Migrated from github.com)
Copy Link

Also you can't write "Fixes #xxxxx" unless it's a complete fix, that screws up the dependency tracking.

Also you can't write "Fixes #xxxxx" unless it's a complete fix, that screws up the dependency tracking.
👍 1
navjotcis commented 2020-12-22 08:38:22 +01:00 (Migrated from github.com)
Copy Link

I have made the suggested changes not it is ready to merge.

I have made the suggested changes not it is ready to merge.
PeterSurda (Migrated from github.com) requested changes 2020-12-22 09:10:59 +01:00
PeterSurda (Migrated from github.com) left a comment

Please fix import.

Please fix import.
src/tests/test_randomtrackingdict.py
PeterSurda (Migrated from github.com) commented 2020-12-22 09:10:02 +01:00

"""Test performance of RandomTrackingDict"""

`"""Test performance of RandomTrackingDict"""`
PeterSurda (Migrated from github.com) commented 2020-12-22 09:10:41 +01:00

Maybe this needs to be 10.0, I'm not fully sure, we'll see once the import is fixed.

Maybe this needs to be `10.0`, I'm not fully sure, we'll see once the import is fixed.
PeterSurda (Migrated from github.com) requested changes 2020-12-25 09:22:35 +01:00
PeterSurda (Migrated from github.com) left a comment

fix

fix
src/network/__init__.py
PeterSurda (Migrated from github.com) commented 2020-12-25 09:22:25 +01:00

why dot at the beginning?

why dot at the beginning?
navjotcis (Migrated from github.com) reviewed 2020-12-25 16:15:00 +01:00
src/network/__init__.py
navjotcis (Migrated from github.com) commented 2020-12-25 16:15:00 +01:00

checking with every possible way

checking with every possible way
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.4
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-10#1688
No description provided.
Delete Branch "bug-fixes14"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?