Bitmessage/PyBitmessage-2024-12-11
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

UI refactoring, part 2 #1394

Open
g1itch wants to merge 14 commits from g1itch/ui-refactoring into v0.6
pull from: g1itch/ui-refactoring
merge into: Bitmessage:v0.6
Conversation 5 Commits 14 Files Changed 15 +2809 -3016
g1itch commented 2018-11-18 16:13:24 +01:00 (Migrated from github.com)
Copy Link

Hello!

In the second part of UI refactoring I moved most of widgets definitions into ui-files, removed autogenerated code and renamed bitmessageui to main.
Minor appearance differences include:

  • Add buttons are not resizing infinitely
  • UPnP checkbox label on tab "Network Settings" of Settings dialog
  • "Resends expire tab" of Settings dialog.

Also maybe I did wrong in retranslateui.

These changes definitely require testing. I'm going to write some soon. But it may make sense to merge this before qt5-wip because of many pylint warnings in obsolete settings and bitmessageui modules.

Hello! In the second part of UI refactoring I moved most of widgets definitions into ui-files, removed autogenerated code and renamed `bitmessageui` to `main`. Minor appearance differences include: * Add buttons are not resizing infinitely * ~~UPnP checkbox label on tab "Network Settings" of Settings dialog~~ * ~~"Resends expire tab" of Settings dialog.~~ Also maybe I did wrong in `retranslateui`. These changes definitely require testing. I'm going to write some soon. ~~But it may make sense to merge this before qt5-wip because of many pylint warnings in obsolete `settings` and `bitmessageui` modules.~~
PeterSurda commented 2018-11-19 12:33:18 +01:00 (Migrated from github.com)
Copy Link

Man this is huge. Does it affect the translation sources? Transifex could delete parts of old translations if they move to a different context.

Man this is huge. Does it affect the translation sources? Transifex could delete parts of old translations if they move to a different context.
PeterSurda commented 2018-11-19 13:37:50 +01:00 (Migrated from github.com)
Copy Link

It looks ok but I'm not going to review it in detail. I checked translation compiling, and that looks like it doesn't break it. There is one major problem though, when I try to run it, the main window briefly pops up and then it crashes:

Loading existing config files from /home/bitmessage/.config/PyBitmessage/
Gtk-Message: Failed to load module "canberra-gtk-module"
2018-11-19 13:36:25 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:25 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
2018-11-19 13:36:25 MainThread __init__.py@965 No indicator plugin found
2018-11-19 13:36:25 MainThread __init__.py@985 No notification.message plugin found
2018-11-19 13:36:30 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:30 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
Segmentation fault
It looks ok but I'm not going to review it in detail. I checked translation compiling, and that looks like it doesn't break it. There is one major problem though, when I try to run it, the main window briefly pops up and then it crashes: ``` Loading existing config files from /home/bitmessage/.config/PyBitmessage/ Gtk-Message: Failed to load module "canberra-gtk-module" 2018-11-19 13:36:25 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated 2018-11-19 13:36:25 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button 2018-11-19 13:36:25 MainThread __init__.py@965 No indicator plugin found 2018-11-19 13:36:25 MainThread __init__.py@985 No notification.message plugin found 2018-11-19 13:36:30 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated 2018-11-19 13:36:30 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button Segmentation fault ```
g1itch commented 2018-11-19 14:40:15 +01:00 (Migrated from github.com)
Copy Link

No, I guess about a half of translations strings will be reset by this changes.

No, I guess about a half of translations strings will be reset by this changes.
g1itch commented 2018-11-22 11:46:08 +01:00 (Migrated from github.com)
Copy Link

Could you please check again? I removed inheritance of RetranslateMixin.

Could you please check again? I removed inheritance of `RetranslateMixin`.
PeterSurda commented 2018-11-22 21:44:54 +01:00 (Migrated from github.com)
Copy Link

No more crash.

No more crash.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-11#1394
No description provided.
Delete Branch "g1itch/ui-refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?