Bitmessage/PyBitmessage-2024-12-13
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 53 Actions Packages Projects Releases 5 Wiki Activity

Fix the issues with non-ASCII characters in path on Windows #1613

Open
g1itch wants to merge 4 commits from g1itch/windows into v0.6
pull from: g1itch/windows
merge into: Bitmessage:v0.6
Conversation 7 Commits 4 Files Changed 4 +46 -53
g1itch commented 2020-04-22 13:15:20 +02:00 (Migrated from github.com)
Copy Link

Hello!

This is the fix for the bug on Windows which was recently reported back in chan. When the messages.dat file path contains unicode characters the exception sqlite3.OperationalError: unable to open database file is raised and PyBitmessage stops loading.

I'm not sure about necessity of the change in class_sqlThread (os.path.join() instead of strings concatenation). The main problem is in encoding of the state.appdata string. I used the solution from https://stackoverflow.com/questions/35833037.

Related issues are: #165, #978

Hello! This is the fix for the bug on Windows which was recently reported back in chan. When the `messages.dat` file path contains unicode characters the exception `sqlite3.OperationalError: unable to open database file` is raised and PyBitmessage stops loading. I'm not sure about necessity of the change in `class_sqlThread` (`os.path.join()` instead of strings concatenation). The main problem is in encoding of the `state.appdata` string. I used the solution from https://stackoverflow.com/questions/35833037. Related issues are: #165, #978
👍 1
PeterSurda commented 2020-04-23 03:36:27 +02:00 (Migrated from github.com)
Copy Link

Thank you, I think it is a step in the right direction. My testing shows that it still doesn't work. I found two issues.

  • an additional fix is needed if the directory with the executable / source contains unicode (as opposed to merely %APPDATA% being localised):
    pybitmessage-encoding2

  • there are at least some cases where it doesn't convert correctly:
    pybitmessage-encoding1

The tests are done on a 64bit Win10 with current updates.

Thank you, I think it is a step in the right direction. My testing shows that it still doesn't work. I found two issues. - an additional fix is needed if the directory with the executable / source contains unicode (as opposed to merely %APPDATA% being localised): ![pybitmessage-encoding2](https://user-images.githubusercontent.com/3815204/80049475-8c38ed00-8545-11ea-8806-32977159d25b.png) - there are at least some cases where it doesn't convert correctly: ![pybitmessage-encoding1](https://user-images.githubusercontent.com/3815204/80049476-8e02b080-8545-11ea-849f-4f750a98d320.png) The tests are done on a 64bit Win10 with current updates.
g1itch commented 2020-04-23 10:49:07 +02:00 (Migrated from github.com)
Copy Link

OK, thanks for hint. I've being able to reproduce it only in portable mode with many debug messages added. Can you please tell me how to get such detailed log in console?

OK, thanks for hint. I've being able to reproduce it only in portable mode with many debug messages added. Can you please tell me how to get such detailed log in console?
PeterSurda commented 2020-04-23 11:26:08 +02:00 (Migrated from github.com)
Copy Link

In the spec file set debug=True and console=True

In the spec file set debug=True and console=True
PeterSurda commented 2020-04-24 05:26:26 +02:00 (Migrated from github.com)
Copy Link

It looks like in my case there is an additional problem, I use a US locale in the OS but created a username with non-US characters. Python doesn't like it and I'm not sure how to fix that other than changing the user locale to something compatible, and relogin. After changing the locale it works even without this PR. Unless someone can report that this actually helped him I'm inclined to reject this PR.

It looks like in my case there is an additional problem, I use a US locale in the OS but created a username with non-US characters. Python doesn't like it and I'm not sure how to fix that other than changing the user locale to something compatible, and relogin. After changing the locale it works even without this PR. Unless someone can report that this actually helped him I'm inclined to reject this PR.
g1itch commented 2020-04-24 13:37:16 +02:00 (Migrated from github.com)
Copy Link

Hmm, I really cannot reproduce the issue with non-ASCII characters in username. What I see is the exception raised when you start PyBitmessage in portable mode from the directory containing non-ASCII characters:

[7372] LOADER: Post-init sys.path is C:\Users\DEBD1~1.BOG\AppData\Local\Temp\_MEI113682
[7372] LOADER: Setting sys.argv
[7372] LOADER: setting sys._MEIPASS
[7372] LOADER: importing modules from CArchive
[7372] LOADER: extracted struct
[7372] LOADER: callfunction returned...
[7372] LOADER: extracted pyimod01_os_path
[7372] LOADER: callfunction returned...
[7372] LOADER: extracted pyimod02_archive
[7372] LOADER: callfunction returned...
[7372] LOADER: extracted pyimod03_importers
[7372] LOADER: callfunction returned...
[7372] LOADER: Installing PYZ archive with Python modules.
[7372] LOADER: PYZ archive: PYZ-00.pyz
[7372] LOADER: Running pyiboot01_bootstrap.py
[7372] LOADER: Running pyi_rth__tkinter.py
[7372] LOADER: Running pyi_rth_pkgres.py
[7372] LOADER: Running pyi_rth_qt4plugins.py
[7372] LOADER: Running pyi_rth_multiprocessing.py
[7372] LOADER: Running bitmessagemain.py
INFO: PyQt Version: 4.11.4
INFO: Qt Version: 4.8.7
Number of threads: 2
Exception in thread SQL:
Traceback (most recent call last):
  File "threading.py", line 801, in __bootstrap_inner
  File "class_sqlThread.py", line 31, in run
OperationalError: unable to open database file
Hmm, I really cannot reproduce the issue with non-ASCII characters in username. What I see is the exception raised when you start PyBitmessage in portable mode from the directory containing non-ASCII characters: ```shell [7372] LOADER: Post-init sys.path is C:\Users\DEBD1~1.BOG\AppData\Local\Temp\_MEI113682 [7372] LOADER: Setting sys.argv [7372] LOADER: setting sys._MEIPASS [7372] LOADER: importing modules from CArchive [7372] LOADER: extracted struct [7372] LOADER: callfunction returned... [7372] LOADER: extracted pyimod01_os_path [7372] LOADER: callfunction returned... [7372] LOADER: extracted pyimod02_archive [7372] LOADER: callfunction returned... [7372] LOADER: extracted pyimod03_importers [7372] LOADER: callfunction returned... [7372] LOADER: Installing PYZ archive with Python modules. [7372] LOADER: PYZ archive: PYZ-00.pyz [7372] LOADER: Running pyiboot01_bootstrap.py [7372] LOADER: Running pyi_rth__tkinter.py [7372] LOADER: Running pyi_rth_pkgres.py [7372] LOADER: Running pyi_rth_qt4plugins.py [7372] LOADER: Running pyi_rth_multiprocessing.py [7372] LOADER: Running bitmessagemain.py INFO: PyQt Version: 4.11.4 INFO: Qt Version: 4.8.7 Number of threads: 2 Exception in thread SQL: Traceback (most recent call last): File "threading.py", line 801, in __bootstrap_inner File "class_sqlThread.py", line 31, in run OperationalError: unable to open database file ```
PeterSurda commented 2020-04-27 09:48:04 +02:00 (Migrated from github.com)
Copy Link

Can you tell me how to trigger it?

Can you tell me how to trigger it?
g1itch commented 2020-04-27 19:11:11 +02:00 (Migrated from github.com)
Copy Link

Can you tell me how to trigger it?

Put executable into the directory with non-ASCII character in it's name. Run it. Go into Settings and set "User Interface -> Run in Portable mode". Restart PyBitmessage.

> Can you tell me how to trigger it? Put executable into the directory with non-ASCII character in it's name. Run it. Go into Settings and set "User Interface -> Run in Portable mode". Restart PyBitmessage.
PeterSurda (Migrated from github.com) reviewed 2021-01-25 10:44:22 +01:00
PeterSurda (Migrated from github.com) left a comment

Ok.

Ok.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-13#1613
No description provided.
Delete Branch "g1itch/windows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?