Bitmessage/PyBitmessage-2024-12-16
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

UI refactoring (part 1) #1092

Merged
g1itch merged 20 commits from ui-refactoring into v0.6 2018-01-30 17:32:38 +01:00
Conversation 9 Commits 20 Files Changed 24 +1263 -1761
g1itch commented 2018-01-11 15:41:14 +01:00 (Migrated from github.com)
Copy Link

Hello!

Here is the first part of UI refactoring. What has been done?

  • most dialogs moved into dialogs module;
  • made common dialogs code reusable;
  • slightly edited about.ui (I think the wiki page image is also needed here);
  • copyright year made smart.

As usual I ready to drop or squash any commit after review.

Hello! Here is the first part of UI refactoring. What has been done? * most dialogs moved into `dialogs` module; * made common dialogs code reusable; * slightly edited `about.ui` (I think the [wiki page image](https://bitmessage.org/w/images/f/f1/Bitmessagelogo-reduced.png) is also needed here); * copyright year made smart. As usual I ready to drop or squash any commit after review.
PeterSurda commented 2018-01-11 16:09:28 +01:00 (Migrated from github.com)
Copy Link

Thank you, this is the type of work that is necessary but I don't like doing it myself. I'll review it soon but it's probably ok.

Thank you, this is the type of work that is necessary but I don't like doing it myself. I'll review it soon but it's probably ok.
g1itch commented 2018-01-23 20:51:48 +01:00 (Migrated from github.com)
Copy Link

Oops, I have broken EmailGatewayDialog. dialog.exec_() not returns account.

Oops, I have broken `EmailGatewayDialog`. `dialog.exec_()` not returns account.
PeterSurda commented 2018-01-25 03:18:39 +01:00 (Migrated from github.com)
Copy Link

I'm reviewing this now, please no more commits in this PR unless it's a bugfix.

I'm reviewing this now, please no more commits in this PR unless it's a bugfix.
g1itch commented 2018-01-25 08:38:32 +01:00 (Migrated from github.com)
Copy Link

OK, that one was last. EmailGatewayDialog didn't close on one of my computers without self.hide().

OK, that one was last. EmailGatewayDialog didn't close on one of my computers without self.hide().
PeterSurda commented 2018-01-30 15:52:31 +01:00 (Migrated from github.com)
Copy Link

There's now a conflict with the offline menu, please resolve. I haven't had a time for a full review yet but I'm working on it.

There's now a conflict with the offline menu, please resolve. I haven't had a time for a full review yet but I'm working on it.
g1itch commented 2018-01-30 16:39:39 +01:00 (Migrated from github.com)
Copy Link

Done rebase.

Done rebase.
👍 1
PeterSurda commented 2018-01-30 17:33:13 +01:00 (Migrated from github.com)
Copy Link

Thank you for this huge amount of work.

Thank you for this huge amount of work.
g1itch commented 2018-01-30 17:39:04 +01:00 (Migrated from github.com)
Copy Link

Now you may probably close #1081, #1040, #1089. #527 maybe remain as guideline.

Now you may probably close #1081, #1040, #1089. #527 maybe remain as guideline.
👍 1
PeterSurda commented 2018-01-30 17:49:48 +01:00 (Migrated from github.com)
Copy Link

Done

Done
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-16#1092
No description provided.
Delete Branch "ui-refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?