Bitmessage/PyBitmessage-2024-12-16
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

Quick fix for #1081 #1096

Merged
g1itch merged 3 commits from ui-fixes into v0.6 2018-01-27 07:46:15 +01:00
Conversation 10 Commits 3 Files Changed 2 +42 -31
g1itch commented 2018-01-25 13:43:03 +01:00 (Migrated from github.com)
Copy Link

With this oneliner "Mark all messages as read" works without error.

With this oneliner "Mark all messages as read" works without error.
PeterSurda commented 2018-01-25 14:02:23 +01:00 (Migrated from github.com)
Copy Link

perhaps it should be 998?

perhaps it should be 998?
PeterSurda commented 2018-01-25 14:04:26 +01:00 (Migrated from github.com)
Copy Link

or even better, can you check if sqlExecuteChunked in helper_sql works correctly and use that instead?

or even better, can you check if sqlExecuteChunked in helper_sql works correctly and use that instead?
g1itch commented 2018-01-25 14:07:43 +01:00 (Migrated from github.com)
Copy Link

If I understand correctly the objective is to take 999 items at a time, in this case the remainder from the division should be 0.

If I understand correctly the objective is to take 999 items at a time, in this case the remainder from the division should be 0.
g1itch commented 2018-01-25 14:08:06 +01:00 (Migrated from github.com)
Copy Link

OK, I'll try.

OK, I'll try.
PeterSurda commented 2018-01-25 14:08:29 +01:00 (Migrated from github.com)
Copy Link

i think if it's 0, it will execute the first chunk with just one item.

i think if it's 0, it will execute the first chunk with just one item.
g1itch commented 2018-01-25 17:54:37 +01:00 (Migrated from github.com)
Copy Link

I don't understand how sqlExecuteChunked() can work without modification of sqlStatement because it contains idCount placeholders.

        markread = sqlExecuteChunked(
            "UPDATE %s SET read = 1 WHERE ackdata IN(%s) AND read=0" % (
                'sent' if self.getCurrentFolder() == 'sent' else 'inbox',
                ','.join('?' * idCount)
            ),
            idCount, *msgids
        )
I don't understand how `sqlExecuteChunked()` can work without modification of `sqlStatement` because it contains `idCount` placeholders. ```python markread = sqlExecuteChunked( "UPDATE %s SET read = 1 WHERE ackdata IN(%s) AND read=0" % ( 'sent' if self.getCurrentFolder() == 'sent' else 'inbox', ','.join('?' * idCount) ), idCount, *msgids ) ```
PeterSurda commented 2018-01-25 18:02:52 +01:00 (Migrated from github.com)
Copy Link

You're right, I missed that one. It can probably be fixed by having a placeholder (e.g. {0}) in the original statement, and replacing it the way you just did but inside each of sqlExecuteChunked loops.

You're right, I missed that one. It can probably be fixed by having a placeholder (e.g. `{0}`) in the original statement, and replacing it the way you just did but inside each of `sqlExecuteChunked` loops.
g1itch commented 2018-01-25 22:10:37 +01:00 (Migrated from github.com)
Copy Link

It probably works, at least for me.

It probably works, at least for me.
g1itch commented 2018-01-25 22:27:57 +01:00 (Migrated from github.com)
Copy Link

I'll drop 0097ea6 If you test and approve this changes.

I'll drop 0097ea6 If you test and approve this changes.
PeterSurda commented 2018-01-25 22:32:09 +01:00 (Migrated from github.com)
Copy Link

Looks ok, I'll test it tomorrow and then merge.

Looks ok, I'll test it tomorrow and then merge.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.3
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-16#1096
No description provided.
Delete Branch "ui-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?