Returning bitmessageqt package back to normal #1280

2018-06-19T16:08:00+02:00

g1itch commented

2018-06-19 16:08:00 +02:00

(Migrated from github.com)

I reverted all changes to init in this commit.

I reverted all changes to __init__ in this commit.

coffeedogs (Migrated from github.com) reviewed 2018-06-19 16:08:00 +02:00

omkar1117 (Migrated from github.com) requested changes 2018-06-23 12:34:49 +02:00

src/bitmessageqt/__init__.py

omkar1117 (Migrated from github.com) commented

2018-06-23 12:31:23 +02:00

write imports first and then from statements later.
Please maintain all the imports in a alphabetic order

write imports first and then from statements later. Please maintain all the imports in a alphabetic order

g1itch (Migrated from github.com) reviewed 2018-06-23 12:38:35 +02:00

src/bitmessageqt/__init__.py

g1itch (Migrated from github.com) commented

2018-06-23 12:38:35 +02:00

There is still a problems with import order in this package. Changed import statements is one of the reasons why the previous commit broke everything.

omkar1117 (Migrated from github.com) reviewed 2018-06-23 12:43:46 +02:00

src/bitmessageqt/__init__.py

omkar1117 (Migrated from github.com) commented

2018-06-23 12:43:45 +02:00

ok. but may I know how come these order break the workflow, so that I can ignore this for future purpose.

g1itch (Migrated from github.com) reviewed 2018-06-23 12:48:30 +02:00

src/bitmessageqt/__init__.py

g1itch (Migrated from github.com) commented

2018-06-23 12:48:30 +02:00

It seems still nobody knows it exactly. Changing the order sometimes can lead to circular import issue, especially in modules like bitmessagemain. That's why for example depends imports standard python logging instead of using debug.

It seems still nobody knows it exactly. Changing the order sometimes can lead to circular import issue, especially in modules like `bitmessagemain`. That's why for example `depends` imports standard python `logging` instead of using `debug`.