Fix floating bugs in test_api #1771

Merged
g1itch merged 3 commits from api into v0.6 2021-08-02 20:51:22 +02:00
g1itch commented 2021-05-30 21:22:54 +02:00 (Migrated from github.com)

Hello!

There are the fixes for some bugs in API tests.

With the first commit .test_shutdown() pass on Fedora but still not on Windows.

The last one is fix for random failure that happens when test_send_broadcast() uses temporary msgid for lookups, e.g. https://buildbot.bitmessage.org/#/builders/25/builds/1095

Hello! There are the fixes for some bugs in API tests. With the first commit `.test_shutdown()` pass on Fedora but still not on Windows. The last one is fix for random failure that happens when test_send_broadcast() uses temporary msgid for lookups, e.g. https://buildbot.bitmessage.org/#/builders/25/builds/1095
PeterSurda (Migrated from github.com) approved these changes 2021-08-02 05:06:22 +02:00
PeterSurda (Migrated from github.com) requested changes 2021-08-02 10:25:17 +02:00
PeterSurda (Migrated from github.com) left a comment

Please make the small change I requested, it's a little bit cleaner.

Please make the small change I requested, it's a little bit cleaner.
PeterSurda (Migrated from github.com) commented 2021-08-02 10:22:29 +02:00
start = time.time()
``` start = time.time() ```
PeterSurda (Migrated from github.com) commented 2021-08-02 10:23:16 +02:00
if time.time() - start > 30.0
``` if time.time() - start > 30.0 ```
PeterSurda (Migrated from github.com) commented 2021-08-02 10:24:19 +02:00
self.fail('PoW is taking too much time: %ss' % int(time.time() - start))
``` self.fail('PoW is taking too much time: %ss' % int(time.time() - start)) ```
PeterSurda (Migrated from github.com) commented 2021-08-02 10:24:34 +02:00

remove line

remove line
g1itch (Migrated from github.com) reviewed 2021-08-02 12:55:36 +02:00
g1itch (Migrated from github.com) commented 2021-08-02 12:55:36 +02:00

OK, thanks for reasonable suggestions

OK, thanks for reasonable suggestions
PeterSurda (Migrated from github.com) approved these changes 2021-08-02 14:08:08 +02:00
This repo is archived. You cannot comment on pull requests.
No description provided.