Bitmessage/PyBitmessage-2024-12-19
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

Updated code quality class doc string, import ignore & comment spaces in setup.py #1817

Merged
kdcis merged 3 commits from v0.6-codequality-setup into v0.6 2021-09-30 13:48:18 +02:00
Conversation 1 Commits 3 Files Changed 1 +4 -4
kdcis commented 2021-08-20 18:54:54 +02:00 (Migrated from github.com)
Copy Link

Added class doc string
Added import ignore comment
Updated comment spaces

Added class doc string Added import ignore comment Updated comment spaces
PeterSurda (Migrated from github.com) approved these changes 2021-08-26 10:41:29 +02:00
g1itch (Migrated from github.com) reviewed 2021-08-26 13:31:53 +02:00
setup.py
g1itch (Migrated from github.com) commented 2021-08-26 13:31:53 +02:00

Ugh! Where in the code you see the docstrings with single quotes? This one is not informative and for me it's the same as no docstring. The proper one is something like "Custom setuptools install command preparing icons"

Ugh! Where in the code you see the docstrings with single quotes? This one is not informative and for me it's the same as no docstring. The proper one is something like "Custom setuptools install command preparing icons"
g1itch (Migrated from github.com) reviewed 2021-08-26 13:32:20 +02:00
setup.py
g1itch (Migrated from github.com) commented 2021-08-26 13:32:19 +02:00

importlib can be used here

importlib can be used here
g1itch (Migrated from github.com) reviewed 2021-08-26 13:32:45 +02:00
setup.py
g1itch (Migrated from github.com) commented 2021-08-26 13:32:45 +02:00

It's better to fill the kwargs.

It's better to fill the kwargs.
PeterSurda (Migrated from github.com) reviewed 2021-08-27 10:31:43 +02:00
setup.py
PeterSurda (Migrated from github.com) commented 2021-08-27 10:31:43 +02:00

I don't understand.

I don't understand.
PeterSurda (Migrated from github.com) requested changes 2021-08-27 10:32:38 +02:00
PeterSurda (Migrated from github.com) left a comment

Please make the requested changes.

Please make the requested changes.
kdcis (Migrated from github.com) reviewed 2021-08-27 15:26:38 +02:00
setup.py
kdcis (Migrated from github.com) commented 2021-08-27 15:26:37 +02:00

Updated

Updated
kdcis (Migrated from github.com) reviewed 2021-08-27 15:26:51 +02:00
setup.py
kdcis (Migrated from github.com) commented 2021-08-27 15:26:51 +02:00

Updated

Updated
g1itch (Migrated from github.com) reviewed 2021-08-27 15:42:18 +02:00
setup.py
g1itch (Migrated from github.com) commented 2021-08-27 15:42:18 +02:00

Just remove these kwargs and TODO if you don't want to use them. The comments are useless.

Just remove these kwargs and TODO if you don't want to use them. The comments are useless.
PeterSurda (Migrated from github.com) reviewed 2021-08-31 10:43:15 +02:00
PeterSurda (Migrated from github.com) left a comment

Please make the changes g1itch requested

Please make the changes g1itch requested
kdcis (Migrated from github.com) reviewed 2021-08-31 19:26:21 +02:00
setup.py
kdcis (Migrated from github.com) commented 2021-08-31 19:26:21 +02:00

Updated as asked by @PeterSurda , Keeping TODO & removed other kwargs comments

Updated as asked by @PeterSurda , Keeping TODO & removed other kwargs comments
PeterSurda (Migrated from github.com) approved these changes 2021-09-03 10:26:09 +02:00
g1itch commented 2021-09-03 13:18:48 +02:00 (Migrated from github.com)
Copy Link

@PeterSurda what's the point of preserving those TODO?

@PeterSurda what's the point of preserving those TODO?
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
PeterSurda
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-19#1817
No description provided.
Delete Branch "v0.6-codequality-setup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?