Move most of the code testing UDP from core tests to test_network #2169

2024-01-15T17:31:01+01:00

PeterSurda commented

2024-01-15 17:31:01 +01:00

(Migrated from github.com)

Hi!

I moved the code causing failures like this into the TestNetwork test case and slightly improved the logic.

FAIL: test_udp (tests.core.TestCore)
check default udp setting and presence of Announcer thread
----------------------------------------------------------------------
Traceback (most recent call last):
 File "/var/lib/buildbot/workers/default/multibuild_child/build/src/tests/core.py", line 331, in test_udp
 self.fail('No self in discovered peers')
AssertionError: No self in discovered peers

Even if it fail there, what I didn't observed so far, the py27 tox environment will be fully executed and coverage won't be decreased to 13%.

Hi! I moved the code causing failures like [this](https://buildbot.bitmessage.org/#/builders/33/builds/19356/steps/4/logs/stdio) into the `TestNetwork` test case and slightly improved the logic. ``` FAIL: test_udp (tests.core.TestCore) check default udp setting and presence of Announcer thread ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/lib/buildbot/workers/default/multibuild_child/build/src/tests/core.py", line 331, in test_udp self.fail('No self in discovered peers') AssertionError: No self in discovered peers ``` Even if it fail there, what I didn't observed so far, the `py27` tox environment will be fully executed and coverage won't be decreased to 13%.

This repo is archived. You cannot comment on pull requests.

No reviewers