Bitmessage/PyBitmessage-2024-12-21
Archived
2
0
Fork 0
Code Issues 168 Pull Requests 52 Actions Packages Projects Releases 5 Wiki Activity

allowing for max outbound connection configuration #940

Merged
ghost merged 1 commits from max-outbound-connection-config into v0.6 2017-02-22 08:54:08 +01:00
Conversation 4 Commits 1 Files Changed 7 +58 -2
ghost commented 2017-01-14 04:51:09 +01:00 (Migrated from github.com)
Copy Link

This allows for the maximum number of connections to be configured in the settings UI.

This allows for the maximum number of connections to be configured in the settings UI.
PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:25:11 +01:00
.gitignore
PeterSurda (Migrated from github.com) commented 2017-02-12 19:25:11 +01:00

please change .dll to src/**/.dll

please change *.dll to src/**/*.dll
PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:27:27 +01:00
src/class_outgoingSynSender.py
@ -78,7 +78,7 @@ class outgoingSynSender(threading.Thread, StoppableThread):
self.stop.wait(2)
PeterSurda (Migrated from github.com) commented 2017-02-12 19:27:27 +01:00

please change getint to safeGetInt

please change getint to safeGetInt
PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:28:21 +01:00
src/protocol.py
PeterSurda (Migrated from github.com) commented 2017-02-12 19:28:21 +01:00

please remove this whole hunk, this has been fixed

please remove this whole hunk, this has been fixed
PeterSurda (Migrated from github.com) reviewed 2017-02-12 19:28:39 +01:00
src/shared.py
PeterSurda (Migrated from github.com) commented 2017-02-12 19:28:39 +01:00

please remove this while hunk as well, this has been fixed as well

please remove this while hunk as well, this has been fixed as well
PeterSurda commented 2017-02-12 19:32:38 +01:00 (Migrated from github.com)
Copy Link

If you do the minor changes I commented upon inside the code, it's good to go, I just need to test if it works, which should be very quick. Please also rebase and PGP sign your commit, and when it's accepted, you can register here: https://tip4commit.com/github/Bitmessage/PyBitmessage and collect a tip. But it must be rebased and PGP signed so that I can do a fast-forward merge. Don't forget to add your PGP pubkey into your github profile.

If you do the minor changes I commented upon inside the code, it's good to go, I just need to test if it works, which should be very quick. Please also rebase and PGP sign your commit, and when it's accepted, you can register here: https://tip4commit.com/github/Bitmessage/PyBitmessage and collect a tip. But it must be rebased and PGP signed so that I can do a fast-forward merge. Don't forget to add your PGP pubkey into your github profile.
ghost commented 2017-02-19 16:24:22 +01:00 (Migrated from github.com)
Copy Link

Sure thing. I'll get these changes made soon.

Sure thing. I'll get these changes made soon.
ghost commented 2017-02-21 22:20:14 +01:00 (Migrated from github.com)
Copy Link

@PeterSurda done.

@PeterSurda done.
PeterSurda commented 2017-02-21 23:26:48 +01:00 (Migrated from github.com)
Copy Link

Thanks. PGP signature looks ok. Landscape.io however complains that ValueException is not valid, my bad, it should be ValueError.

Thanks. PGP signature looks ok. Landscape.io however complains that ValueException is not valid, my bad, it should be ValueError.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working as it's supposed to

  
build

Related to building or build system

  
dependencies

Pull requests that update a dependency file

  
developers

The issue is relevant mainly for developers rather than users

  
documentation

   
duplicate

   
enhancement

New feature

  
formatting

Code or UI text formatting

  
invalid

   
legal

   
mobile

Frontend for mobile devices (kivy)

  
obsolete

   
packaging

   
performance

   
protocol

Protocol change

  
question

   
refactoring

   
regression

Some issue, fixed in the past, appears again

  
security

   
test

   
translation

   
usability

   
wontfix
No Label
bug
build
dependencies
developers
documentation
duplicate
enhancement
formatting
invalid
legal
mobile
obsolete
packaging
performance
protocol
question
refactoring
regression
security
test
translation
usability
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.6.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-21#940
No description provided.
Delete Branch "max-outbound-connection-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?