Test cases for shared.py #2201

2024-03-28T04:14:36+01:00

anand-skss commented

2024-03-28 04:14:36 +01:00

(Migrated from github.com)

Test cases for shared.py

* Test cases for shared.py

PeterSurda (Migrated from github.com) requested changes 2024-04-05 01:05:24 +02:00

PeterSurda (Migrated from github.com) left a comment

one typo but otherwise ok

src/tests/test_shared.py

PeterSurda (Migrated from github.com) commented

2024-04-05 01:05:10 +02:00

this looks like a typo, it should be assert_called_once

this looks like a typo, it should be `assert_called_once`

PeterSurda (Migrated from github.com) requested changes 2024-04-13 15:20:20 +02:00

src/tests/test_shared.py

PeterSurda (Migrated from github.com) commented

2024-04-13 15:18:56 +02:00

maybe use addresses from samples

PeterSurda (Migrated from github.com) commented

2024-04-13 15:20:11 +02:00

use constants

anand-skss (Migrated from github.com) reviewed 2024-04-15 04:43:55 +02:00

src/tests/test_shared.py

anand-skss (Migrated from github.com) commented

2024-04-15 04:43:55 +02:00

os.stat returns stat_result type object, so, while mocking return value stat_obj is required.

PeterSurda (Migrated from github.com) reviewed 2024-04-16 06:16:37 +02:00

src/tests/test_shared.py

PeterSurda (Migrated from github.com) commented

2024-04-16 06:16:37 +02:00

I mean the numbers should be constants

PeterSurda (Migrated from github.com) approved these changes 2024-04-18 04:38:06 +02:00

This repo is archived. You cannot comment on pull requests.

No reviewers

PeterSurda

No Label

No Milestone

No project

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bitmessage/PyBitmessage-2024-12-22#2201